Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: light theme #134

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Feat: light theme #134

merged 2 commits into from
Dec 15, 2024

Conversation

Velrok
Copy link
Contributor

@Velrok Velrok commented Nov 29, 2024

Adding light theme as an option

Potential fix for my original request: #131

It looks like this:

Screenshot 2024-11-29 at 18 01 49

Which seams close enough to the reference to me:

Screenshot 2024-11-29 at 18 04 52

Not done

  • I've not made changes to the readme mainly because I'd not know how to keep the screenshots consistent.
  • I'm not sure what the doc/tags are used for so I left them as is.
  • The theme already has a day filter which I'd originally expected to be this actual light theme. But for the sake of not breaking current setups I've not changed that. Maybe something to concider.

@Velrok Velrok changed the title Add light theme Feat: light theme Nov 29, 2024
@@ -32,9 +33,10 @@ M.create_filter_command = function()
complete = function()
return {
"classic",
"light",
"machine",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This moved because I've sorted the entries alphabetically.

@mksonkar
Copy link

mksonkar commented Nov 29, 2024

@Velrok This is great man! Well done.
@loctvl842 Please verify and merge this

@zhengpd
Copy link
Contributor

zhengpd commented Nov 30, 2024

Great! Maybe "light (filter sun)" could also be added with this.

@Velrok
Copy link
Contributor Author

Velrok commented Dec 4, 2024

FYI I found the sun theme in the CSS:

[data-theme=monokai-pro-light-filter-sun] {
    --color-dark2: #d2c9c4;
    --color-dark1: #eee5de;
    --color-background: #f8efe7;
    --color-text: #2c232e;
    --color-accent1: #ce4770;
    --color-accent2: #d4572b;
    --color-accent3: #b16803;
    --color-accent4: #218871;
    --color-accent5: #2473b6;
    --color-accent6: #6851a2;
    --color-dimmed1: #72696d;
    --color-dimmed2: #92898a;
    --color-dimmed3: #a59c9c;
    --color-dimmed4: #beb5b3;
    --color-dimmed5: #d2c9c4;
    --color-panel: #fdf7f3;
    --color-light: #fffcfa
}

So yea could take a look when I have more time.

@loctvl842 loctvl842 merged commit 6a39986 into loctvl842:master Dec 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants