Add Scheduler Feature for Running Cron Jobs #735
Conversation
| @@ -96,6 +96,13 @@ jobs: | |||
| REDIS_URL: redis://localhost:${{job.services.redis.ports[6379]}} | |||
| DATABASE_URL: postgres://postgres:postgres@localhost:5432/postgres_test | |||
|
|
|||
| - name: scheduler | |||
| run: cargo run -- generate scheduler | |||
There was a problem hiding this comment.
i would add some more value for example
$ cargo run -- generate job send_emails --cron '* * * * ..'
Added `send_emails` to scheduler jobs
Total 12 jobs in `config/development.yaml` under `scheduler:`.
This will upsert a schedule record.
You can also experiment with english-to-cron libraries
$ cargo run -- generate job send_emails --at 'every sunday at 1pm'
Cron schedule: 0 * * * 1 *
Added `send_emails` to jobs
Total 12 jobs in `config/development.yaml` under `scheduler:`.
Notice we generate a job
If we say scheduler it is the thing that runs jobs
Its also a good opportunity to centralize and sharpen our concepts and terminology:
taskis a one time, you run it any way you likejobis a repeat on a schedule, run by theschedulerworkeris something that performs abackground jobfrom a queue
| # A list of jobs to be scheduled. | ||
| jobs: | ||
| # The name of the job. | ||
| - name: "Run command" |
There was a problem hiding this comment.
use a hashmap instead of vec, id instead of name
jobs:
send_emails:
...
There was a problem hiding this comment.
agree.
changed: 19d2a0f
| # The name of the job. | ||
| - name: "Run command" | ||
| # The type of job. | ||
| shell: |
There was a problem hiding this comment.
I think it should be just:
run: "...command.."
shell: true | false
| # The cron expression defining the job's schedule. | ||
| cron: "*/1 * * * * *" | ||
| output: silent | ||
| tags: |
There was a problem hiding this comment.
can we do tags: ['base', 'infra'] in YAML example?
| ```console | ||
| $ LOCO_ENV=test blo-cli scheduler --config ./config/scheduler.yaml --list | ||
| # job_name cron tags kind | ||
| 1 add text */1 * * * * * base, infra Shell { command: "echo loco >> ./scheduler.txt" } |
There was a problem hiding this comment.
there are some libraries that do "english to cron" and "cron to english"
might be good to add a "cron to english" description here, based on the cron expression that's saved in the configuration
This PR introduces the ability to schedule and run cron jobs within the Loco framework. The new scheduler functionality includes: