Merge pull request #9 from roseliux/install-rubocop

Install rubocop

.rubocop.yml

@@ -0,0 +1,9 @@
+AllCops:
+  Exclude:
+    - 'heartcheck-newrelic.gemspec'
+
+Style/Documentation:
+  Enabled: false
+
+Naming/RescuedExceptionsVariableName:
+  Enabled: false

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 

bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'heartcheck/newrelic'

bin/rspec

@@ -1,17 +1,18 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 #
 # This file was generated by Bundler.
 #
 # The application 'rspec' is installed as part of a gem, and
 # this file is here to facilitate running it.
 #
 
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile',
+                                           Pathname.new(__FILE__).realpath)
 
-require "rubygems"
-require "bundler/setup"
+require 'rubygems'
+require 'bundler/setup'
 
-load Gem.bin_path("rspec-core", "rspec")
+load Gem.bin_path('rspec-core', 'rspec')

heartcheck-newrelic.gemspec

@@ -20,6 +20,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'rubocop'
 
   spec.required_ruby_version = '>= 2.3'
 end

lib/heartcheck/checks/newrelic.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module Heartcheck
   module Checks
     class Newrelic < Base
       def validate
         NewRelic::Agent.increment_metric('Custom/NewRelicMonitoring')
-      rescue => e
+      rescue StandardError => e
         append_error('could not report to New Relic server.')
         append_error(e.message)
       end

lib/heartcheck/newrelic.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'newrelic_rpm'
 require 'heartcheck'
 require 'heartcheck/checks/newrelic'

lib/heartcheck/newrelic/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Heartcheck
   module Newrelic
-    VERSION = '0.2.0'.freeze
+    VERSION = '0.2.0'
   end
 end

spec/heartcheck/checks/newrelic_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe Heartcheck::Checks::Newrelic do
   describe '#validate' do
     it 'does not record an error when everything is fine' do

spec/spec_helper.rb

@@ -1,4 +1,6 @@
-$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+# frozen_string_literal: true
+
+$LOAD_PATH.unshift File.expand_path('../lib', __dir__)
 require 'heartcheck/newrelic'
 
 RSpec.configure do |config|