Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConstantTile with nodata: support correct celltype conversion #3552

Closed
wants to merge 7 commits into from
Closed

ConstantTile with nodata: support correct celltype conversion #3552

wants to merge 7 commits into from

Conversation

jdries
Copy link
Contributor

@jdries jdries commented Oct 10, 2024 •
edited
Loading

#3525

Overview

Test and fix for the issue above.

Checklist

  • ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.
  • Module Hierarchy updated, if necessary
  • docs guides update, if necessary
  • New user API has useful Scaladoc strings
  • Unit tests added for bug-fix or new feature

Closes #3525

@pomadchin pomadchin added the bug label Oct 10, 2024
moradology
moradology suggested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@moradology moradology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small things but I think this looks good after that

raster/src/main/scala/geotrellis/raster/ConstantTile.scala Outdated Show resolved Hide resolved
raster/src/main/scala/geotrellis/raster/ConstantTile.scala Outdated Show resolved Hide resolved
@pomadchin pomadchin self-requested a review October 19, 2024 13:41
@pomadchin pomadchin mentioned this pull request Oct 28, 2024
Merged
@pomadchin
Copy link
Member

pomadchin commented Oct 28, 2024 •
edited
Loading

Unfotunately pushes into this PR branch are forbidden, I forked off to cleanup the fix a bit: #3553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moradology moradology Awaiting requested review from moradology

@pomadchin pomadchin Awaiting requested review from pomadchin

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert NODATA ByteConstantTile and ShortConstantCellType: unexpected result
3 participants
@jdries @pomadchin @moradology