Fixed the issue that vrt.xml is empty when written out #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the issue that the generated vrt.xml is empty when writing out COG
pomadchin
approved these changes
Jul 8, 2024
| @@ -172,6 +172,7 @@ object VRT { | |||
| doctype = null | |||
| ) | |||
|
|
|||
| writer.flush() | |||
There was a problem hiding this comment.
Thanks! I wonder how did it work before (:
Comment on lines
30
to
+46
| case class VRT( | ||
| gridBounds: GridBounds[Int], | ||
| layout: LayoutDefinition, | ||
| extent: Extent, | ||
| cellType: CellType, | ||
| crs: CRS, | ||
| bands: List[Elem] | ||
| ) { | ||
| gridBounds: GridBounds[Int], | ||
| layout: LayoutDefinition, | ||
| extent: Extent, | ||
| cellType: CellType, | ||
| crs: CRS, | ||
| bands: List[Elem] | ||
| ) { | ||
| lazy val (layoutCols, layoutRows) = gridBounds.width * layout.tileCols -> gridBounds.height * layout.tileRows | ||
|
|
||
| lazy val re: RasterExtent = RasterExtent(extent, layoutCols, layoutRows) | ||
|
|
||
| /** | ||
| * Calculates GeoTransform attributes | ||
| * | ||
| * TODO: refactor, code style kept to follow GDAL: https://github.com/OSGeo/gdal/blob/9a21e8dcaf36a7e046ee87cd57c8c03812dd20ed/gdal/frmts/sde/sdedataset.cpp | ||
| */ | ||
| * Calculates GeoTransform attributes | ||
| * | ||
| * TODO: refactor, code style kept to follow GDAL: https://github.com/OSGeo/gdal/blob/9a21e8dcaf36a7e046ee87cd57c8c03812dd20ed/gdal/frmts/sde/sdedataset.cpp | ||
| */ |
There was a problem hiding this comment.
Could u revert these changes and preserve the original fmt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
writer.flush()when writing xml to vrt, fix the problem of writing empty vrt.xml when writing out COG.