-
Notifications
You must be signed in to change notification settings - Fork 0
add docs for polaris catalog #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎊 PR Preview has been successfully built and deployed to https://localstack-snowflake-docs-preview-pr-73.surge.sh 🎊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, kudos for adding these docs. Super excited to see the enhanced support for Iceberge tables, and integration with Polaris Catalog! 🚀 🚀
| test | | ||
+----------+ | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: would be cool to maybe add a screenshot of Polaris catalog in action, displaying the Iceberge table created above. (but shoudn't be blocking, could be added in a future iteration 👍 )
Co-authored-by: Waldemar Hummer <[email protected]>
Co-authored-by: Waldemar Hummer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see Polaris catalog integration documented 💪
STORAGE_BASE_URL = 's3://test-bucket/' | ||
STORAGE_AWS_ROLE_ARN = 'arn:aws:iam::000000000000:role/test-bucket-290de95d' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace test-bucket
in two lines with $BUCKET_NAME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be executed in a SQL client so need to hardcode the S3 bucket name and role.
No description provided.