Skip to content

add docs for polaris catalog #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 15, 2025
Merged

add docs for polaris catalog #73

merged 8 commits into from
May 15, 2025

Conversation

HarshCasper
Copy link
Member

No description provided.

Copy link

github-actions bot commented May 8, 2025

🎊 PR Preview has been successfully built and deployed to https://localstack-snowflake-docs-preview-pr-73.surge.sh 🎊

Copy link
Contributor

@hovaesco hovaesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, kudos for adding these docs. Super excited to see the enhanced support for Iceberge tables, and integration with Polaris Catalog! 🚀 🚀

| test |
+----------+
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would be cool to maybe add a screenshot of Polaris catalog in action, displaying the Iceberge table created above. (but shoudn't be blocking, could be added in a future iteration 👍 )

@HarshCasper HarshCasper requested a review from hovaesco May 15, 2025 08:32
Copy link
Contributor

@hovaesco hovaesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see Polaris catalog integration documented 💪

Comment on lines 121 to 122
STORAGE_BASE_URL = 's3://test-bucket/'
STORAGE_AWS_ROLE_ARN = 'arn:aws:iam::000000000000:role/test-bucket-290de95d'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace test-bucket in two lines with $BUCKET_NAME

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be executed in a SQL client so need to hardcode the S3 bucket name and role.

@HarshCasper HarshCasper merged commit 086b349 into main May 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants