-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/scheduler/aws regressions #77
Conversation
Should this fix be added upstream in https://github.com/moto/moto? I think this is a valid candidate 😄 |
Since I added the tests not in moto but in localstack I doubt that Bert will accept these fixes - and I want to unblock the customer asap - this is why I though to create the PR into our branch. |
I see, but I think this is overhead for us to maintain, @viren-nadkarni will chime in, but every commit we add here is additional maintenance burden at every moto bump. The testing in moto is not too complicated, and adding those should be straightforward, hopefully. |
@bentsku is right, this must be submitted upstream. I'm happy to bump moto-ext as soon as it is merged. |
submitted upstream in this PR: getmoto#8478 |
Fixing regressions for event bridge scheduler CRUD.
AWS Snapshot Tests are in this PR: localstack/localstack#12114