Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/scheduler/aws regressions #77

Closed
wants to merge 7 commits into from

Conversation

maxhoheiser
Copy link
Member

Fixing regressions for event bridge scheduler CRUD.
AWS Snapshot Tests are in this PR: localstack/localstack#12114

@maxhoheiser maxhoheiser added the bug Something isn't working label Jan 8, 2025
@maxhoheiser maxhoheiser self-assigned this Jan 8, 2025
@maxhoheiser maxhoheiser requested review from zaingz and joe4dev and removed request for bentsku January 8, 2025 15:22
@bentsku
Copy link

bentsku commented Jan 8, 2025

Should this fix be added upstream in https://github.com/moto/moto? I think this is a valid candidate 😄

@maxhoheiser
Copy link
Member Author

Should this fix be added upstream in https://github.com/moto/moto? I think this is a valid candidate 😄

Since I added the tests not in moto but in localstack I doubt that Bert will accept these fixes - and I want to unblock the customer asap - this is why I though to create the PR into our branch.

@bentsku
Copy link

bentsku commented Jan 8, 2025

Since I added the tests not in moto but in localstack I doubt that Bert will accept these fixes - and I want to unblock the customer asap - this is why I though to create the PR into our branch.

I see, but I think this is overhead for us to maintain, @viren-nadkarni will chime in, but every commit we add here is additional maintenance burden at every moto bump. The testing in moto is not too complicated, and adding those should be straightforward, hopefully.

@viren-nadkarni
Copy link
Member

@bentsku is right, this must be submitted upstream. I'm happy to bump moto-ext as soon as it is merged.

@maxhoheiser
Copy link
Member Author

submitted upstream in this PR: getmoto#8478

@maxhoheiser maxhoheiser closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants