Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localstack_template #1

Merged
merged 40 commits into from
Aug 8, 2024
Merged

Localstack_template #1

merged 40 commits into from
Aug 8, 2024

Conversation

lakkeger
Copy link
Contributor

@lakkeger lakkeger commented Jul 3, 2024 •
edited
Loading

Motivation

DevContainers providing a template tool for easy guided setup for different kind of projects. By creating such template for LocalStack we could help our users to start to produce value with LocalStack in shorter period of time.

Changes

  • dind template
  • dood template
  • implement scenario testing
  • add scenario test suite
  • add scenario tests for dind
  • add scenario tests for dood

@lakkeger lakkeger self-assigned this Jul 3, 2024
@lakkeger lakkeger force-pushed the localstack_template branch from 74f3f4c to 9db22fc Compare July 4, 2024 11:31
lakkeger added 16 commits July 4, 2024 13:11
@lakkeger
feat: improve error handling
a60239f
@lakkeger
ci: separate scenario testing into its own pipeline
67dc95a
@lakkeger
fix: improve exit conditions
d012685
@lakkeger
docs: add READMEs
85fa780
@lakkeger
fix: add cli test to postCreateCommand in dind template
8ee88a3
@lakkeger
feat: add merging behaviour in scenario build script for options not …
b5a2876 
…defined in template
@lakkeger
fix: update imageVariant proposals
5778f4c
@lakkeger
fix: inherit auth token in devcontainer
d26756e
@lakkeger
feat: add scenario testing
c9fb66f
@lakkeger
fix: add exit code to scenario code suite to reflec results
913e6e6
@lakkeger
fix: create volume folder for dind in smoke test
f0e3f87
@lakkeger
fix: remove focal from scenario test
29c2115
@lakkeger
ci: add LOCALSTACK_AUTH_TOKEN
afca093
@lakkeger
feat: add ci key support
bfa04f6
@lakkeger
feat: add network and ls container removal in scenario tests
0dc4fcf
@lakkeger
fix: change default volume name
4eb6238
@lakkeger lakkeger marked this pull request as ready for review July 26, 2024 09:18
pinzon
pinzon approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some questions about things that looked weird to me.

Also it would be great if this PR is tested by someone with devcontainer experience.

@lakkeger lakkeger requested review from dfangl and removed request for bartsdev and HarshCasper August 2, 2024 07:59
dfangl
dfangl approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, just some minor comments. Would love to get a section about which option to use under what circumstances in at some point, but not blocking.

@lakkeger lakkeger merged commit f983ec1 into main Aug 8, 2024
5 checks passed
@lakkeger lakkeger deleted the localstack_template branch August 8, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@pinzon pinzon pinzon approved these changes

Assignees

@lakkeger lakkeger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lakkeger @dfangl @pinzon