1.0.0-beta8 release #100
Merged
1.0.0-beta8 release #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newly added local custodian code restriction should also be considered when opting to use cached results from previous address lookups. This is particularly useful when there are multiple address lookup elements in a form but they are using different local custodian codes.
Long term storage of Webform submission data in an off-site database. Work in progress.
Alternate Webform submission entity storage class for storing and retrieving entities from the LTS database.
- PHP class to copy Webform submissions to Long term storage. - Cron job to periodically copy Webform submissions to Long term storage. - Deploy hook to copy Webform submissions to Long term storage. - Personally Identifiable Information redaction before copying Webform submissions to Long term storage. - A requirement hook implementation to warn against misconfiguration.
Fixed return value of LtsCopy::findCopyTargets(). Also, ensured that no Webform handlers run while Webform submissions are copied to Long term storage.
Updated scope of Personally Identifiable Information.
Listing and viewing Webform submissions in Long term storage.
Fix for Personally Identifiable Information redaction. Date elements from this module were unaccounted for.
Spots and redacts any email address, postcode, and number within the text value of a textarea field.
Tests following functionalities: - LtsCopy's ability to copy both new and existing Webform submissions. - LtsStorageForWebformSubmission's ability to copy into the LTS database. - PIIRedactor's ability to correctly identify which Webform fields should be redacted.
PHPStan is incorrectly inferring the type of the $entity_type object used within _localgov_forms_lts_get_webform_submission_storage_schema(). Inferred type is Drupal\Core\Entity\EntityTypeInterface. Expected type is Drupal\Core\Entity\ContentEntityTypeInterface. Actual type is Drupal\Core\Entity\ContentEntityType which is an instance of Drupal\Core\Entity\ContentEntityTypeInterface.
…ddev-testing Feature/long term storage ddev testing
The address lookup validation process was loosing existing form error messages set by other parts of a form. Some of its own error messages also got lost. WIP.
Fix: Address lookup caching
The LocalGov address lookup element should not tamper with error messages raised by other elements. It should also remain inactive when none of its subelements are marked as required.
The address selection dropdown was not appearing after a form submission error involving the address lookup element. Also: - removed some unused and commented out Javascript code. - improved code comments.
Updated error message text in test code to match updated error handling.
We should have a choice of PII redaction plugins before saving Webform submissions in the long term storage database. WIP.
…feature/long-term-storage
Moved PII redaction functionality from the localgov_forms_lts submodule into the localgov_forms module in the form of a plugin.
Adding the `localgov_forms_lts:copy` Drush command. This command copies all existing Webform submissions into the Long Term Storage (LTS). This is particularly useful soon after the localgov_forms_lts module has been installed.
A config form for: - Activating or deactivating copying to LTS database. - Selecting a PII redactor plugin if PII redaction is necessary.
These constants represent the newly added localgov_forms_lts module configuration.
Adding custom error messages to several subelements of the Address lookup element. This is for better UX.
Selecting an address following lookup and then manually altering the selected address skipped validation. Fixed now.
Fix: Address lookup validation
Feature: Long term storage of Webform submission data
|
@Adnan-cds are we happy to push ahead and release this? |
|
@andybroomfield will try to find time to test this too. |
finnlewis
approved these changes
Dec 10, 2024
andybroomfield
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
New functionality:
Bug fix: