if enable login and not signed in, then auto pop up user panel #4617
Conversation
|
@vual is attempting to deploy a commit to the LobeHub Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
the
size:XS
|
👍 @vual Thank you for raising your pull request and contributing to our Community |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4617 +/- ##
========================================
Coverage 92.51% 92.52%
========================================
Files 511 512 +1
Lines 36784 36755 -29
Branches 3398 2403 -995
========================================
- Hits 34032 34007 -25
+ Misses 2752 2748 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
这个不好。真要做强校验的方案，我建议考虑怎么去实现下这个 #4382 |
This is not good. If you really want to implement a strong verification solution, I suggest you consider how to implement this #4382 |
|
还有另外一个相关的：#3200 |
There is another related one: #3200 |
我大概看了下这两个讨论，我觉得我的改动是有区别的，他们讨论那个可以后面考虑下怎么去实现，但目前我这改动只是相当于在未登录情况下，帮用户自动点了一下左上角的头像，并不是强制登录，鼠标点一下悬浮窗外也是会关闭弹窗的，重点是在于提示用户需要登录，以及在哪里点登录，因为很多用户第一次打开页面使用，他并不清楚登录在哪里，也不清楚可以头像那边可以点击。 |
I took a look at these two discussions, and I think my changes are different. The one they discussed can be implemented later, but at present, my changes are just equivalent to automatically clicking for users without logging in. Clicking on the avatar in the upper left corner does not force login. Clicking the mouse on the floating window will also close the pop-up window. The key point is to prompt the user to log in and where to click to log in, because many users do not open the page for the first time. I don’t know where to log in, and I don’t know where to click on the avatar. |
|
现在的已经实现了如果点需要权限的按钮，自动跳转登陆页。 我觉得这个程度已经够了。不需要再主动弹出来一下面板 |
Now it has been implemented that if you click a button that requires permission, it will automatically jump to the login page. I think this level is enough. No need to actively pop up the panel anymore |
你说的这个场景是怎么触发？目前遇到的是，只有发个消息出去，才会提示未登录。还有种场景是，很多人不知道头像那边可以点击弹出菜单。 |
How did you trigger this scene? What I am currently encountering is that only when I send a message will I be prompted that I am not logged in. Another scenario is that many people don’t know that there is a pop-up menu that can be clicked on the avatar. |
|
|
感觉并不冲突吧，自动弹出来，感觉会更友好一些，而且可以让用户知道头像那边可以点击，现状是我遇到很多人不知道头像那边可以点击。 |
如果是为了达成这个目标，不应该用这种交互方案，应该换成用户引导的形式。类似我之前做的 
|
If it is to achieve this goal, this interactive solution should not be used and should be replaced by a user-guided form. Similar to what I did before
|
这种也可以。 |
This is also possible. |
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
开启了登录，但用户未登录，则打开页面时，自动弹出用户面板，提示用户需要进行登录/注册。
📝 补充信息 | Additional Information