Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SELF-438: Fix Radio Attribute Typing #533

Merged
merged 1 commit into from
Aug 6, 2024
Merged

SELF-438: Fix Radio Attribute Typing #533

merged 1 commit into from
Aug 6, 2024

Conversation

NateWaldschmidt
Copy link
Contributor

@NateWaldschmidt NateWaldschmidt commented Aug 6, 2024 •
edited by jira bot
Loading

JIRA

Description

  • Fixes types of attribute props

Reviewer Checklist

This section is to be filled out by reviewers

Testing

  • This code was tested by somebody other than the developer. Do not merge until this has been done.

@NateWaldschmidt NateWaldschmidt marked this pull request as ready for review August 6, 2024 16:25
@NateWaldschmidt NateWaldschmidt requested a review from a team as a code owner August 6, 2024 16:25
@guardrails GuardRails
Copy link

guardrails bot commented Aug 6, 2024 •
edited
Loading

⚠️ We detected 6 security issues in this pull request:

Vulnerable Libraries (6)
Severity Details
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
High pkg:npm/[email protected] (t) upgrade to: > 1.53.0

More info on how to fix Vulnerable Libraries in JavaScript.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@NateWaldschmidt NateWaldschmidt force-pushed the SELF-438/radio-attrs-typing branch from 9b620f7 to 222fcd3 Compare August 6, 2024 16:27
@NateWaldschmidt NateWaldschmidt merged commit 60b506e into main Aug 6, 2024
3 of 5 checks passed
@NateWaldschmidt NateWaldschmidt deleted the SELF-438/radio-attrs-typing branch August 6, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthpant92 siddharthpant92 siddharthpant92 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NateWaldschmidt @siddharthpant92