Skip to content

Commit

Permalink
fix: primevue build (#466)
Browse files Browse the repository at this point in the history
  • Loading branch information
NateWaldschmidt authored Apr 5, 2024
1 parent 13c0467 commit 065e111
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 6 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## v2.0.29

- Make `PrimeVue` and external dependency

## v2.0.28

- Upgrades `Vue` to latest `v3.4` release.
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lob/ui-components",
"version": "2.0.28",
"version": "2.0.29",
"engines": {
"node": ">=20.2.0",
"npm": ">=10.2.0"
Expand Down
2 changes: 0 additions & 2 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,11 @@ import 'primeicons/primeicons.css';
import * as components from './components';
import * as mixins from './mixins';
import * as configs from './config';
import PrimeVue from 'primevue/config';
import { App } from 'vue';

const ComponentLibrary = {
install(app: App) {
app.use(configs.constants);
app.use(PrimeVue, { unstyled: true });
for (const mixinName in mixins) {
// @ts-ignore
const mixin = mixins[mixinName];
Expand Down
2 changes: 1 addition & 1 deletion vite.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default defineConfig({
rollupOptions: {
// make sure to externalize deps that shouldn't be bundled
// into your library
external: ['vue'],
external: ['vue', /primevue\/.+/],
output: {
// Provide global variables to use in the UMD build
// for externalized deps
Expand Down

0 comments on commit 065e111

Please sign in to comment.