2.x: grunt improvements #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
beporter
commented
Jan 21, 2015
beporter
commented
beporter
force-pushed
the
f/grunt-improvements
branch
from
b777cef
to
992ee74
Compare
The PHP test runner should really be a MultiTask so it fires tests sequentially (they clobber each other inside the VM otherwise.) This would also allow us to have the individual filenames available in the grunt task for watching php files instead of having to register an event watcher using `grunt.event.on()`.
So the basic idea here is that instead of binding a hidden `grunt.even.on('watch)` event, we could register a multiTask directly, and loop over the supplied filenames.
The problem seems to be that grunt-contrib-watch doesn't expect to hand off to a multiTask, so things don't work correctly. There seems to be an approach for handling this kind of case laid out here though: https://www.npmjs.com/package/grunt-contrib-watch#compiling-files-as-needed
Needs more experimentation.
beporter
force-pushed
the
f/grunt-improvements
branch
from
992ee74
to
f6df1c9
Compare
|
❗ This PR is now targeting the wrong branch. It needs to be recreated to target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.