Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional wallet query param to indicate to the LN_SERVICE which wallet was used to authenticate #175

Open
wants to merge 1 commit into
base: luds
Choose a base branch
from

Conversation

steliosrammos
Copy link
Contributor

Add an optional wallet query param to indicate to the LN_SERVICE which wallet was used to authenticate.

Add an optional `wallet` query param to indicate to the `LN_SERVICE` which wallet was used to authenticate.
@fiatjaf fiatjaf changed the title Update 04.md Add an optional wallet query param to indicate to the LN_SERVICE which wallet was used to authenticate Aug 2, 2022
@fiatjaf
Copy link
Collaborator

fiatjaf commented Aug 2, 2022

Is this a terrible thing that destroys privacy?

@steliosrammos
Copy link
Contributor Author

All that is shared is the wallet name. What are the privacy concerns you are thinking of?

Since it's an optional param, a wallet could also prompt a user before hitting the LN_SERVICE to ask if they want to share that info.

@fiatjaf
Copy link
Collaborator

fiatjaf commented Aug 2, 2022

I don't know. I generally don't care about that kind of privacy, just raising the question.

@benthecarman
Copy link
Contributor

This could help fingerprint users, however, could be beneficial if we get into a world where some wallets support feature A,B,C and other wallets support X,Y,Z. Seems like PTLCs, BOLT12, AMP, Taro, etc are all moving this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants