Merge pull request #232 from lnu-norge/fix-overscroll-mobile

Fix overscroll mobile + tests
lnu-norge · Feb 29, 2024 · 1206f7a · 1206f7a
2 parents 5df7969 + f8b4a84
commit 1206f7a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app/views/reviews/_review_content.html.erb b/app/views/reviews/_review_content.html.erb
@@ -1,10 +1,10 @@
 <% show_full_review = false unless defined?(:show_full_review) %>
 
 <h3 class="reset-header-styles">
-  <span class="font-bold flex gap-1">
+  <span class="font-bold inline-flex gap-1 relative">
     <%= inline_svg_tag 'star', class: 'text-pink-600' if review.star_rating %>
     <%= review.star_rating %>
-    <span class="sr-only"><%= t("reviews.stars_given", count: review.star_rating) %></span>
+    <span class="sr-only"><%= t("reviews.stars_given", count: review.star_rating.to_i) %></span>
     <% unless review.star_rating %>
       -
       <% if review.type_of_contact %>

diff --git a/spec/features/user_manages_space_spec.rb b/spec/features/user_manages_space_spec.rb
@@ -27,14 +27,14 @@
       fill_in "space_post_number", with: space.post_number
       find("body").click # Blur from field
 
-      expect(page).to have_text(I18n.t("space_create.any_of_these.one"))
+      expect(page).to have_content(I18n.t("space_create.any_of_these.one"))
 
       click_on I18n.t("space_create.none_are_duplicates.one")
 
       tom_select("select#space_space_type_ids", option_id: space_type.id)
       tom_select("select#space_space_group_title", option_id: space_group.title)
       click_on I18n.t("helpers.submit.create", model: Space.model_name.human)
-      expect(page).to have_text(space.title)
+      expect(page).to have_content(space.title)
     end
   end