Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "force-new-window" argument to launcher #725

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

JAFeltran
Copy link
Contributor

Adds the --force-new-window argument to sirius-hla-as-ap-launcher, an argument that allows bypassing any checks and the creation of a new window.

@fernandohds564
Copy link
Contributor

@JAFeltran , why do you need this option?

@JAFeltran
Copy link
Contributor Author

@JAFeltran , why do you need this option?

When trying to access the GUI using SSH on Windows, the _subprocess.getoutput('ps h -A -o pid,sess,command= | grep "[s]irius-hla-as-ap-launcher.py"') doesn't return "" as expected, causing the code to enter the if returnval block even when it shouldn't.

@fernandohds564
Copy link
Contributor

@JAFeltran , why do you need this option?

When trying to access the GUI using SSH on Windows, the _subprocess.getoutput('ps h -A -o pid,sess,command= | grep "[s]irius-hla-as-ap-launcher.py"') doesn't return "" as expected, causing the code to enter the if returnval block even when it shouldn't.

In this case, isn't it better to fix the bug instead of creating this option?

@JAFeltran
Copy link
Contributor Author

@JAFeltran , why do you need this option?

When trying to access the GUI using SSH on Windows, the _subprocess.getoutput('ps h -A -o pid,sess,command= | grep "[s]irius-hla-as-ap-launcher.py"') doesn't return "" as expected, causing the code to enter the if returnval block even when it shouldn't.

In this case, isn't it better to fix the bug instead of creating this option?

I investigated it and couldn't really find out how to fix the bug, especially since I don't have a Windows computer to do the testing. It actually doesn't even return an error that can be treated with try. Also, the RF team needed to be able to access the interface through Windows, and I didn't want to keep them waiting too long.

@fernandohds564
Copy link
Contributor

@JAFeltran , why do you need this option?

When trying to access the GUI using SSH on Windows, the _subprocess.getoutput('ps h -A -o pid,sess,command= | grep "[s]irius-hla-as-ap-launcher.py"') doesn't return "" as expected, causing the code to enter the if returnval block even when it shouldn't.

In this case, isn't it better to fix the bug instead of creating this option?

I investigated it and couldn't really find out how to fix the bug, especially since I don't have a Windows computer to do the testing. It actually doesn't even return an error that can be treated with try. Also, the RF team needed to be able to access the interface through Windows, and I didn't want to keep them waiting too long.

I understand, @JAFeltran. Good call!

In this case, if we simply bypass the check when we recognize the OS is windows, would it solve the problem? What do you think of this approach?

@JAFeltran
Copy link
Contributor Author

@JAFeltran , why do you need this option?

When trying to access the GUI using SSH on Windows, the _subprocess.getoutput('ps h -A -o pid,sess,command= | grep "[s]irius-hla-as-ap-launcher.py"') doesn't return "" as expected, causing the code to enter the if returnval block even when it shouldn't.

In this case, isn't it better to fix the bug instead of creating this option?

I investigated it and couldn't really find out how to fix the bug, especially since I don't have a Windows computer to do the testing. It actually doesn't even return an error that can be treated with try. Also, the RF team needed to be able to access the interface through Windows, and I didn't want to keep them waiting too long.

I understand, @JAFeltran. Good call!

In this case, if we simply bypass the check when we recognize the OS is windows, would it solve the problem? What do you think of this approach?

Thanks! Unfortunately, I don't think this would work, as the problem is specifically when a Windows computer uses SSH to access a Linux computer and open the interface. So, it wouldn't be able to recognize the OS as Windows. We can still add the bypass though, as it may be useful, but it won't solve this particular problem.

@JAFeltran JAFeltran merged commit 0c82c3d into master Nov 26, 2024
1 check passed
@anacso17 anacso17 deleted the force_window branch December 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants