IVU Feedforward GUI #716
Merged
IVU Feedforward GUI #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelLyra8
requested review from
xresende,
fernandohds564,
pnallin and
ericonr
fernandohds564
approved these changes
Oct 18, 2024
pnallin
approved these changes
Oct 18, 2024
anacso17
reviewed
Oct 21, 2024
@RafaelLyra8, the waveform PV represents the concatenation of all the 4 individual waveforms (correctors' currents). Should we split the plot into 4, one for each corrector? |
I think it should be one plot for all 4 cors, with the option to select which ones are being rendered. |
|
also, white background for the plot is out standard |
anacso17
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt IVU Feedforward GUI to show the IVU parameters
