Change lpc17 i2c driver to accept any size of command in MasterCmdRead #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavosr8
force-pushed
the
i2c-writeread-driver
branch
3 times, most recently
from
afeba5f
to
70b234f
Compare
augustofg
requested changes
Feb 15, 2024
modules/cdce906.c
Outdated
| @@ -570,7 +570,7 @@ int cdce906_read_cfg(uint8_t chip_id, cdce906_cfg* cfg) | |||
| int ret = 0; | |||
|
|
|||
| if (i2c_take_by_chipid(chip_id, &i2c_addr, &i2c_id, (TickType_t)10)) { | |||
| i2c_trans = xI2CMasterWriteRead(i2c_id, i2c_addr, 0x00, data, sizeof(data)); | |||
| i2c_trans = xI2CMasterWriteRead(i2c_id, i2c_addr, 0x00, 1, data, sizeof(data)); | |||
There was a problem hiding this comment.
You forgot to replace the literal 0x00 with a pointer to a local variable set to 0x00 here.
gustavosr8
force-pushed
the
i2c-writeread-driver
branch
from
70b234f
to
0b2feec
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.