Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rate limits configureable #153

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

kannapoix
Copy link
Contributor

@kannapoix kannapoix commented Aug 22, 2024

Closes #49
Make rate limits period and threshold configurable by adding 'rate_limit_count' and 'rate_limit_period' to configuration option.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (259de8b) to head (8d34e5b).
Report is 31 commits behind head on master.

Files with missing lines Patch % Lines
src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #153   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           1       1           
  Lines         105     128   +23     
======================================
- Misses        105     128   +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kannapoix kannapoix marked this pull request as ready for review August 25, 2024 01:33
@kannapoix kannapoix changed the title Make rate limits configureable. Make rate limits configureable Aug 25, 2024
@orbitalturtle orbitalturtle self-requested a review August 28, 2024 22:21
@dunxen dunxen self-requested a review August 31, 2024 15:17
@orbitalturtle
Copy link
Collaborator

Thanks for this PR @kannapoix :) I'll finally take a look on Monday.

config_spec.toml Outdated Show resolved Hide resolved
@dunxen
Copy link
Collaborator

dunxen commented Oct 9, 2024

This dropped off my radar recently. ごめんなさい 🙇

Feel free to squash the last commit for specifying the secs suffix.

Otherwise this LGTM!

Add 'rate_limit_count' and 'rate_limit_period' to configuration option.
@kannapoix
Copy link
Contributor Author

kannapoix commented Oct 15, 2024

@dunxen No problems. 確認ありがとうございます ✨
Commits squashed.

When is the right time to squash commits?
I thought it was bad to squash commits during a review, because changing the commit number makes comments unassociated with a commit. So I always squash them after a reviewer asks me to(just like you did).
Is this OK, or should I organize commits when I feel it is necessary?

@dunxen
Copy link
Collaborator

dunxen commented Oct 15, 2024

When is the right time to squash commits? I thought it was bad to squash commits during a review, because changing the commit number makes comments unassociated with a commit. So I always squash them after a reviewer asks me to(just like you did). Is this OK, or should I organize commits when I feel it is necessary?

You are 100% correct! You did the right thing to leave the fixup commit for review.

@dunxen
Copy link
Collaborator

dunxen commented Oct 15, 2024

I'll wait a little while for @orbitalturtle to have a final look, but this does LGTM so I think it can be merged some time today, otherwise :)

@dunxen dunxen merged commit ea35b47 into lndk-org:master Nov 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Make Rate Limits Configurable
3 participants