-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rate limits configureable #153
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #153 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 1 1
Lines 105 128 +23
======================================
- Misses 105 128 +23 ☔ View full report in Codecov by Sentry. |
4ffdb95
to
df74d7c
Compare
Thanks for this PR @kannapoix :) I'll finally take a look on Monday. |
This dropped off my radar recently. ごめんなさい 🙇 Feel free to squash the last commit for specifying the Otherwise this LGTM! |
Add 'rate_limit_count' and 'rate_limit_period' to configuration option.
711a7b6
to
8d34e5b
Compare
@dunxen No problems. 確認ありがとうございます ✨ When is the right time to squash commits? |
You are 100% correct! You did the right thing to leave the fixup commit for review. |
I'll wait a little while for @orbitalturtle to have a final look, but this does LGTM so I think it can be merged some time today, otherwise :) |
Closes #49
Make rate limits period and threshold configurable by adding 'rate_limit_count' and 'rate_limit_period' to configuration option.