server: correctly convert invoice features

[mrfelton]

There is probably a better way to do this, but this does resolve the issue and ensures that the feature bits returned when fetching/decoding an invoice correctly match those set in the invoice.

---

This pull request primarily focuses on refactoring the feature conversion logic in the src/server.rs file of the project. The changes include the addition of new imports, modifying function parameters, and replacing previous feature conversion logic with new, more specific conversion functions.

Here are the key changes:

1. New imports added:

   • src/server.rs: Imported BlindedHopFeatures and Bolt12InvoiceFeatures from the lightning::ln::features module. This change suggests that these types will be used in the codebase, likely for feature conversion.

2. Changes in function parameters:

   • src/server.rs: In the generate_bolt12_invoice_contents function, the features parameter now uses the convert_invoice_features function instead of convert_features. This change indicates a shift in how invoice features are being converted.
   • src/server.rs: In the convert_blinded_pay_info function, the features parameter now uses the convert_hop_features function instead of convert_features. This change suggests a new approach to converting hop features.

3. Replacement of feature conversion logic:

   • src/server.rs: The previous generic convert_features function and the feature_bit_from_id function have been removed. Instead, two new conversion functions, convert_invoice_features and convert_hop_features, have been introduced. These changes indicate a move towards more specific feature conversion functions, likely for better accuracy and maintainability.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (25e3e2d) to head (16f520f).

Additional details and impacted files

@@          Coverage Diff           @@
##           master    #145   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           1       1           
  Lines          97      97           
======================================
  Misses         97      97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[orbitalturtle]

@mrfelton Nice! I'll take a look this evening.

[orbitalturtle]

@mrfelton Looks like this needs a rebase since I just merged another PR. But looks good to me once that's done.

[mrfelton]

Rebased