new lba models -- porting from the other PR #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnbera
force-pushed
the
new_lba_models
branch
from
e7f1c21 to
ba9628f
Compare
ssms/config/config.py
Outdated
| @@ -568,6 +568,55 @@ def boundary_config_to_function_params(boundary_config: dict) -> dict: | |||
| "n_particles": 3, | |||
| "simulator": cssm.lba_angle, | |||
| }, | |||
| "lba_angle_3_v2": { | |||
There was a problem hiding this comment.
We might want to consistently keep the lba naming convention: A , b instead of z and a?
There was a problem hiding this comment.
for now keeping the a/z naming since it will break a lot of current data analysis pipelines (will look into it again soon after).
|
@krishnbera ping on this |
* add shrink spot simple with restricted range on r parameters * bump version * add model to theta processor
…ndom_states if called in quick succession (#64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.