Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Trask Stalnaker <[email protected]>
  • Loading branch information
lmolkova and trask authored Oct 29, 2024
1 parent 06787c6 commit a3fd6a6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions model/database/common.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ groups:
# conditionally_required: if available
- ref: db.target.name
brief: >
Cosmos DB container name.
Cosmos DB container or another entity that the operation is acting upon.
note: >
It is RECOMMENDED to capture the value as provided by the application without attempting to do any case normalization.
requirement_level:
Expand Down Expand Up @@ -76,6 +76,6 @@ groups:
sampling_relevant: true
requirement_level:
conditionally_required: >
If readily available and if a database call is performed on a single target.
If readily available and if a database operation is performed on a single target.
The target name MAY be parsed from the query text,
in which case it SHOULD be the single target name in the query.
2 changes: 1 addition & 1 deletion model/database/spans.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ groups:
examples: ['mynamespace']
- ref: db.target.name
sampling_relevant: true
brief: The HBase table or namespace name.
brief: The HBase table or another entity that the operation is acting upon.
requirement_level:
conditionally_required: If applicable.
note: >
Expand Down

0 comments on commit a3fd6a6

Please sign in to comment.