Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(demo): Use server settings directly from the common package #1726

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

literat
Copy link
Collaborator

@literat literat commented Oct 23, 2024

Description

Common package is untranspiled and cannot be used via package name in Vite config. So I have tried to use it directly and it works.

Additional context

nrwl/nx#17019

Issue reference

https://jira.almacareer.tech/browse/DS-1506

@github-actions github-actions bot added the bug Something isn't working label Oct 23, 2024
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit ac70f4c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6718fc98fa2997000856740f
😎 Deploy Preview https://deploy-preview-1726--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit ac70f4c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6718fc98dd22e80008a91c3f

@literat literat marked this pull request as ready for review October 23, 2024 13:42
@literat literat requested review from pavelklibani, curdaj and a team as code owners October 23, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants