Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(web-react): Introduce Migration Guide to version 3 #1723

Open
wants to merge 2 commits into
base: integration/BC-v3-design-tokens
Choose a base branch
from

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

https://jira.almacareer.tech/browse/DS-1492

@github-actions github-actions bot added the feature New feature or request label Oct 22, 2024
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit be2fe66
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6717bd8cac87f90008ca276c
😎 Deploy Preview https://deploy-preview-1723--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 91 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 9 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit be2fe66
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6717bd8cb3afb8000895c018
😎 Deploy Preview https://deploy-preview-1723--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

### Button and ButtonLink: Removed `inverted` Variant

The `inverted` variant was removed from the `Button` and `ButtonLink` components.
Use themes instead to switch the color scheme.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to an additional migration guide?

@@ -0,0 +1,10 @@
// @ts-ignore: No declaration -- The library is not installed; we don't need to install it for fixtures.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not ignore these fixtures by the TypeScript compiler?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants