Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(web): Document component changes into the Migration Guide #DS-1489 #1697

Merged

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen requested a review from a team as a code owner October 10, 2024 14:44
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 10, 2024
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 47da197
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67165c948222a900086b494b

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 47da197
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67165c94db84f200087e2d7b
😎 Deploy Preview https://deploy-preview-1697--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 91 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 83 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Oct 10, 2024

Coverage Status

coverage: 96.838%. remained the same
when pulling 572c270 on docs/web-migration-components
into e7c27d7 on docs/web-migration-general-changes.

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

docs/migrations/web/MIGRATION-v3.md Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
@crishpeen crishpeen force-pushed the docs/web-migration-general-changes branch from 5728b54 to db21506 Compare October 17, 2024 07:38
@crishpeen crishpeen force-pushed the docs/web-migration-components branch from f990226 to 7891cc3 Compare October 17, 2024 09:39
@crishpeen crishpeen force-pushed the docs/web-migration-general-changes branch from cbfc143 to 1539c9f Compare October 17, 2024 11:16
@crishpeen crishpeen force-pushed the docs/web-migration-components branch from d385594 to 7becc0e Compare October 17, 2024 11:16
@crishpeen crishpeen force-pushed the docs/web-migration-general-changes branch from 1539c9f to e7c27d7 Compare October 17, 2024 14:21
@crishpeen crishpeen force-pushed the docs/web-migration-components branch from 7becc0e to 572c270 Compare October 17, 2024 14:22
@crishpeen crishpeen force-pushed the docs/web-migration-general-changes branch from e7c27d7 to b783fd5 Compare October 17, 2024 14:41
@crishpeen crishpeen force-pushed the docs/web-migration-components branch from 572c270 to 06fc04b Compare October 17, 2024 14:42
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen crishpeen force-pushed the docs/web-migration-components branch from 06fc04b to a75c075 Compare October 21, 2024 13:51
Base automatically changed from docs/web-migration-general-changes to integration/BC-v3-design-tokens October 21, 2024 13:51
@crishpeen crishpeen force-pushed the docs/web-migration-components branch from a75c075 to 47da197 Compare October 21, 2024 13:52
@crishpeen crishpeen merged commit 85c6833 into integration/BC-v3-design-tokens Oct 21, 2024
20 checks passed
@crishpeen crishpeen deleted the docs/web-migration-components branch October 21, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants