-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clang-format] Add null-terminated path option (#123921) #123926
Open
createyourpersonalaccount
wants to merge
8
commits into
llvm:main
Choose a base branch
from
createyourpersonalaccount:fix-git-clang-format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+29
−18
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9dfbb9a
[clang-format] Add null-terminated path option (#123921)
createyourpersonalaccount 6342476
do not print anything but list of files when null is enabled
createyourpersonalaccount 6b9460a
improve help string
createyourpersonalaccount 343fa15
improve print function to accept list of files
createyourpersonalaccount e2ecb4b
rename null option to print0
createyourpersonalaccount 9bd8510
order command-line arguments alphabetically
createyourpersonalaccount ab12a7e
use new print function to print file lists
createyourpersonalaccount c47ce3c
remove default value from print_filenames argument
createyourpersonalaccount File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is verbose and null a combination that should be supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a good point, should they be mutually exclusive? I.e. if both are specified an error message is printed. I don't think
--verbose
is meaningful because--null
does not have extra information to print. I will try to write a patch for that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HazardyKnusperkeks Do you have an input on this? Right now it's just ignoring
--verbose
.