-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow/release-binaries: Checkout sources before downloading artifacts #109349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actions/checkout step will clear the current directory, so we need to checkout the sources first so that the downloaded artifacts won't be deleted.
@llvm/pr-subscribers-github-workflow Author: Tom Stellard (tstellar) ChangesThe actions/checkout step will clear the current directory, so we need to checkout the sources first so that the downloaded artifacts won't be deleted. Full diff: https://github.com/llvm/llvm-project/pull/109349.diff 1 Files Affected:
diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml
index 925912df6843e4..f24e25879b96bd 100644
--- a/.github/workflows/release-binaries.yml
+++ b/.github/workflows/release-binaries.yml
@@ -420,6 +420,14 @@ jobs:
attestations: write # For artifact attestations
steps:
+ - name: Checkout Release Scripts
+ uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+ with:
+ sparse-checkout: |
+ llvm/utils/release/github-upload-release.py
+ llvm/utils/git/requirements.txt
+ sparse-checkout-cone-mode: false
+
- name: 'Download artifact'
uses: actions/download-artifact@6b208ae046db98c579e8a3aa621ab581ff575935 # v4.1.1
with:
@@ -442,14 +450,6 @@ jobs:
name: ${{ needs.prepare.outputs.release-binary-filename }}-attestation
path: ${{ needs.prepare.outputs.release-binary-filename }}.jsonl
- - name: Checkout Release Scripts
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- with:
- sparse-checkout: |
- llvm/utils/release/github-upload-release.py
- llvm/utils/git/requirements.txt
- sparse-checkout-cone-mode: false
-
- name: Install Python Requirements
run: |
pip install --require-hashes -r ./llvm/utils/git/requirements.txt
|
Ping. |
boomanaiden154
approved these changes
Oct 1, 2024
tru
approved these changes
Oct 1, 2024
/cherry-pick 8f2aa9d |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Oct 1, 2024
…cts (llvm#109349) The actions/checkout step will clear the current directory, so we need to checkout the sources first so that the downloaded artifacts won't be deleted. (cherry picked from commit 8f2aa9d)
/pull-request #110664 |
VitaNuo
pushed a commit
to VitaNuo/llvm-project
that referenced
this pull request
Oct 2, 2024
…cts (llvm#109349) The actions/checkout step will clear the current directory, so we need to checkout the sources first so that the downloaded artifacts won't be deleted.
VitaNuo
pushed a commit
to VitaNuo/llvm-project
that referenced
this pull request
Oct 2, 2024
…cts (llvm#109349) The actions/checkout step will clear the current directory, so we need to checkout the sources first so that the downloaded artifacts won't be deleted.
Sterling-Augustine
pushed a commit
to Sterling-Augustine/llvm-project
that referenced
this pull request
Oct 3, 2024
…cts (llvm#109349) The actions/checkout step will clear the current directory, so we need to checkout the sources first so that the downloaded artifacts won't be deleted.
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this pull request
Oct 4, 2024
…cts (llvm#109349) The actions/checkout step will clear the current directory, so we need to checkout the sources first so that the downloaded artifacts won't be deleted.
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Oct 11, 2024
…cts (llvm#109349) The actions/checkout step will clear the current directory, so we need to checkout the sources first so that the downloaded artifacts won't be deleted. (cherry picked from commit 8f2aa9d)
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Oct 11, 2024
…cts (llvm#109349) The actions/checkout step will clear the current directory, so we need to checkout the sources first so that the downloaded artifacts won't be deleted. (cherry picked from commit 8f2aa9d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actions/checkout step will clear the current directory, so we need to checkout the sources first so that the downloaded artifacts won't be deleted.