Skip to content

Commit

Permalink
[clang][ASTImporter] Fix -Wpessimizing-move in ASTImporter.cpp (NFC)
Browse files Browse the repository at this point in the history
/llvm-project/clang/lib/AST/ASTImporter.cpp:371:20: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
       return std::move(Err);
              ^
/llvm-project/clang/lib/AST/ASTImporter.cpp:371:20: note: remove std::move call here
       return std::move(Err);
              ^~~~~~~~~~   ~
/llvm-project/clang/lib/AST/ASTImporter.cpp:380:22: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
         return std::move(Err);
                ^
/llvm-project/clang/lib/AST/ASTImporter.cpp:380:22: note: remove std::move call here
              return std::move(Err);
                     ^~~~~~~~~~   ~
2 errors generated.
  • Loading branch information
DamonFool committed Sep 6, 2024
1 parent 6fb39e4 commit 30a9cac
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions clang/lib/AST/ASTImporter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ namespace clang {
auto *ToInheritedFrom = const_cast<TemplateParmDeclT *>(
importChecked(Err, D->getDefaultArgStorage().getInheritedFrom()));
if (Err)
return std::move(Err);
return Err;
if (!ToInheritedFrom->hasDefaultArgument()) {
// Resolve possible circular dependency between default value of the
// template argument and the template declaration.
Expand All @@ -377,7 +377,7 @@ namespace clang {
.getInheritedFrom()
->getDefaultArgument());
if (Err)
return std::move(Err);
return Err;
ToInheritedFrom->setDefaultArgument(Importer.getToContext(),
ToInheritedDefaultArg);
}
Expand Down

0 comments on commit 30a9cac

Please sign in to comment.