fixup! [CIR][ABI] Implement basic struct CC lowering for x86_64 #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ABI alignment and preferred alignment fields were swapped (per [1], the ABI alignment should be 1 and the preferred alignment should be 8), leading to incorrect struct size calculations. Fixes llvm#911 Fixes llvm#915 Fixes llvm#916 Fixes llvm#917 Fixes llvm#918 Fixes llvm#919 Fixes llvm#920 Fixes llvm#921 Fixes llvm#922 Fixes llvm#925 Fixes llvm#926 Fixes llvm#929 Fixes llvm#930 [1] llvm/llvm-project@8eadf21
|
Hmm, looks like all of these XFAILs were incorporated into the rebase of 25a9860, so we probably want to amend that instead. |
|
I guess you can just name this commit accordingly for the rebase so that it'll absorb properly next time. |
bcardosolopes
approved these changes
Oct 7, 2024
smeenai
changed the title
|
Okay, the rebase won't be perfect because of subsequent changes, but this should be a good starting point for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ABI alignment and preferred alignment fields were swapped (per [1],
the ABI alignment should be 1 and the preferred alignment should be 8),
leading to incorrect struct size calculations.
Fixes #911
Fixes #915
Fixes #916
Fixes #917
Fixes #918
Fixes #919
Fixes #920
Fixes #921
Fixes #922
Fixes #925
Fixes #926
Fixes #929
Fixes #930
[1] llvm/llvm-project@8eadf21