Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRGen] Complex unary increment and decrement operator #790

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

Lancern
Copy link
Member

@Lancern Lancern commented Aug 14, 2024

This PR adds CIRGen and LLVMIR lowering for unary increment and decrement expressions of complex types.

Currently blocked by #789 .

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once you rebase now that the dep has landed.

This patch adds CIRGen and LLVMIR lowering for unary increment and decrement
expressions of complex types.
@Lancern Lancern marked this pull request as ready for review August 15, 2024 12:53
@Lancern Lancern requested a review from lanza as a code owner August 15, 2024 12:53
@Lancern
Copy link
Member Author

Lancern commented Aug 15, 2024

Rebased.

@bcardosolopes bcardosolopes merged commit c1900b7 into llvm:main Aug 15, 2024
8 checks passed
@Lancern Lancern deleted the complex-incdec branch August 16, 2024 01:18
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
This PR adds CIRGen and LLVMIR lowering for unary increment and
decrement expressions of complex types.

Currently blocked by llvm#789 .
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
This PR adds CIRGen and LLVMIR lowering for unary increment and
decrement expressions of complex types.

Currently blocked by llvm#789 .
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
This PR adds CIRGen and LLVMIR lowering for unary increment and
decrement expressions of complex types.

Currently blocked by llvm#789 .
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
This PR adds CIRGen and LLVMIR lowering for unary increment and
decrement expressions of complex types.

Currently blocked by llvm#789 .
lanza pushed a commit that referenced this pull request Nov 5, 2024
This PR adds CIRGen and LLVMIR lowering for unary increment and
decrement expressions of complex types.

Currently blocked by #789 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants