[CIR][CIRGen][LowerToLLVM] Add address space attribute for pointer type #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lancern
requested changes
May 15, 2024
seven-mile
force-pushed
the
addrspace-for-ptr-type
branch
from
78b09d3 to
6229950
Compare
orbiri
reviewed
May 17, 2024
bcardosolopes
approved these changes
May 18, 2024
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
…pe (llvm#606) This is the prelude of address space support. Linked issue: llvm#418 . - Add the attribute and implement asm format & type conversion. - Make ops like `cir.global` and `cir.get_global` aware of address space, and solve the latter flag. - Relax the restriction of default alloca address space. Then we can use correct address spaces for languages like OpenCL in future.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
…pe (llvm#606) This is the prelude of address space support. Linked issue: llvm#418 . - Add the attribute and implement asm format & type conversion. - Make ops like `cir.global` and `cir.get_global` aware of address space, and solve the latter flag. - Relax the restriction of default alloca address space. Then we can use correct address spaces for languages like OpenCL in future.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
…pe (llvm#606) This is the prelude of address space support. Linked issue: llvm#418 . - Add the attribute and implement asm format & type conversion. - Make ops like `cir.global` and `cir.get_global` aware of address space, and solve the latter flag. - Relax the restriction of default alloca address space. Then we can use correct address spaces for languages like OpenCL in future.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
…pe (#606) This is the prelude of address space support. Linked issue: #418 . - Add the attribute and implement asm format & type conversion. - Make ops like `cir.global` and `cir.get_global` aware of address space, and solve the latter flag. - Relax the restriction of default alloca address space. Then we can use correct address spaces for languages like OpenCL in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the prelude of address space support. Linked issue: #418 .
I want to solve it by these steps:
addressSpaceCastingand (existing)addressSpaceInGlobalVarclang::CK_AddressSpaceConversionas a new kind ofcir.cast. Also fix the corresponding occurrences.cir.globalandcir.get_globalaware of address space, and solve the latter flag.Revert to this PR itself, which includes:
cir.ptr<T[, $addrspace]>cir.ptr<T[, addrspace($addrspace)]>addrspace = 0extendedskipDefaultBuilders = 1, tell me if it's not a good practice😉AST -> CIR -> LLVMpipeline