Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][CIRGen] Add missing visitor for ParenExpr #428

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[CIR][CIRGen] Add missing visitor for ParenExpr #428

merged 1 commit into from
Jan 31, 2024

Conversation

YazZz1k
Copy link
Contributor

@YazZz1k YazZz1k commented Jan 29, 2024 •
edited
Loading

Compilation of the following test

void foo6(A* a1) {
  A a2 = (*a1);
}

fails with.

NYI
UNREACHABLE executed at /home/huawei/cir/repo/llvm-project/clang/lib/CIR/CodeGen/CIRGenExprAgg.cpp:175!

Commit adds required visitor and fixes the issue.

@bcardosolopes
Copy link
Member

@lanza just rebased and this has the side effect of breaking GH PR workflow, making it impossible to review, apologies. Please rebase!

bcardosolopes
bcardosolopes approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@bcardosolopes bcardosolopes merged commit e7a6bba into llvm:main Jan 31, 2024
5 of 6 checks passed
lanza pushed a commit that referenced this pull request Mar 23, 2024
@YazZz1k @lanza
[CIR][CIRGen] Add missing visitor for ParenExpr (#428)
0c894c9 
Compilation of the following test
```
void foo6(A* a1) {
  A a2 = (*a1);
}
```
fails with.
```
NYI
UNREACHABLE executed at /home/huawei/cir/repo/llvm-project/clang/lib/CIR/CodeGen/CIRGenExprAgg.cpp:175!
```
Commit adds required visitor and fixes the issue.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@YazZz1k @lanza
[CIR][CIRGen] Add missing visitor for ParenExpr (llvm#428)
2310ad5 
Compilation of the following test
```
void foo6(A* a1) {
  A a2 = (*a1);
}
```
fails with.
```
NYI
UNREACHABLE executed at /home/huawei/cir/repo/llvm-project/clang/lib/CIR/CodeGen/CIRGenExprAgg.cpp:175!
```
Commit adds required visitor and fixes the issue.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@YazZz1k @lanza
[CIR][CIRGen] Add missing visitor for ParenExpr (#428)
5e066b4 
Compilation of the following test
```
void foo6(A* a1) {
  A a2 = (*a1);
}
```
fails with.
```
NYI
UNREACHABLE executed at /home/huawei/cir/repo/llvm-project/clang/lib/CIR/CodeGen/CIRGenExprAgg.cpp:175!
```
Commit adds required visitor and fixes the issue.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@YazZz1k @lanza
[CIR][CIRGen] Add missing visitor for ParenExpr (#428)
774b299 
Compilation of the following test
```
void foo6(A* a1) {
  A a2 = (*a1);
}
```
fails with.
```
NYI
UNREACHABLE executed at /home/huawei/cir/repo/llvm-project/clang/lib/CIR/CodeGen/CIRGenExprAgg.cpp:175!
```
Commit adds required visitor and fixes the issue.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@YazZz1k @lanza
[CIR][CIRGen] Add missing visitor for ParenExpr (llvm#428)
fd14920 
Compilation of the following test
```
void foo6(A* a1) {
  A a2 = (*a1);
}
```
fails with.
```
NYI
UNREACHABLE executed at /home/huawei/cir/repo/llvm-project/clang/lib/CIR/CodeGen/CIRGenExprAgg.cpp:175!
```
Commit adds required visitor and fixes the issue.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@YazZz1k @lanza
[CIR][CIRGen] Add missing visitor for ParenExpr (#428)
000f9f7 
Compilation of the following test
```
void foo6(A* a1) {
  A a2 = (*a1);
}
```
fails with.
```
NYI
UNREACHABLE executed at /home/huawei/cir/repo/llvm-project/clang/lib/CIR/CodeGen/CIRGenExprAgg.cpp:175!
```
Commit adds required visitor and fixes the issue.
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
@YazZz1k @lanza
[CIR][CIRGen] Add missing visitor for ParenExpr (llvm#428)
a38c827 
Compilation of the following test
```
void foo6(A* a1) {
  A a2 = (*a1);
}
```
fails with.
```
NYI
UNREACHABLE executed at /home/huawei/cir/repo/llvm-project/clang/lib/CIR/CodeGen/CIRGenExprAgg.cpp:175!
```
Commit adds required visitor and fixes the issue.
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@YazZz1k @lanza
[CIR][CIRGen] Add missing visitor for ParenExpr (llvm#428)
bb487a5 
Compilation of the following test
```
void foo6(A* a1) {
  A a2 = (*a1);
}
```
fails with.
```
NYI
UNREACHABLE executed at /home/huawei/cir/repo/llvm-project/clang/lib/CIR/CodeGen/CIRGenExprAgg.cpp:175!
```
Commit adds required visitor and fixes the issue.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@YazZz1k @lanza
[CIR][CIRGen] Add missing visitor for ParenExpr (llvm#428)
8fb64e6 
Compilation of the following test
```
void foo6(A* a1) {
  A a2 = (*a1);
}
```
fails with.
```
NYI
UNREACHABLE executed at /home/huawei/cir/repo/llvm-project/clang/lib/CIR/CodeGen/CIRGenExprAgg.cpp:175!
```
Commit adds required visitor and fixes the issue.
lanza pushed a commit that referenced this pull request Nov 5, 2024
@YazZz1k @lanza
[CIR][CIRGen] Add missing visitor for ParenExpr (#428)
16587a9 
Compilation of the following test
```
void foo6(A* a1) {
  A a2 = (*a1);
}
```
fails with.
```
NYI
UNREACHABLE executed at /home/huawei/cir/repo/llvm-project/clang/lib/CIR/CodeGen/CIRGenExprAgg.cpp:175!
```
Commit adds required visitor and fixes the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YazZz1k @bcardosolopes