New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][CodeGen] initial support for dynamic_cast #426

Merged

bcardosolopes merged 3 commits into llvm:main from Lancern:dynamic-cast

Feb 2, 2024

Member

Lancern commented Jan 28, 2024

This PR introduces CIR CodeGen support for dynamic_cast.

The full feature set of dynamic_cast is not fully implemented in this PR as it's already pretty large. This PR only include support for downcasting and sidecasting a pointer or reference. dynamic_cast<void *> is not yet implemented.

lanza force-pushed the main branch from 4e069c6 to 79d4dc7 Compare

January 29, 2024 23:34

Member

bcardosolopes commented Jan 30, 2024

@lanza just rebased and this has the side effect of breaking GH PR workflow, making it impossible to review, apologies. Please rebase!


          [CIR][CodeGen] initial support for dynamic_cast

ba4b5aa

This patch introduces CIR CodeGen support for dynamic_cast. As an initial step,
this patch only adds support for cases where the destination type is not void*.
Support for dynamic_cast to void* will be added in future patches.

Lancern force-pushed the dynamic-cast branch from 511dad6 to ba4b5aa Compare

January 30, 2024 14:11

Member Author

Lancern commented Jan 30, 2024

Please rebase!

@bcardosolopes Rebased.

bcardosolopes requested changes

View reviewed changes

Member

bcardosolopes left a comment

Thanks for adding dynamic_cast support this is pretty cool and for your patience. Only few minor comments to address and it should be good to go!

clang/lib/CIR/CodeGen/CIRGenCall.cpp Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenExprCXX.cpp Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp Show resolved Hide resolved

clang/test/CIR/CodeGen/dynamic-cast.cpp Show resolved Hide resolved


          Fix issues in reviews

5e25553

bcardosolopes approved these changes

View reviewed changes

Member

bcardosolopes left a comment

This looks good, one one last minor changed needed (will pre-approve and merge once it's done)

clang/lib/CIR/CodeGen/CIRGenExprCXX.cpp Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp Show resolved Hide resolved


          Add assert for unreachable op

b64aaf0

bcardosolopes approved these changes

View reviewed changes

Member

bcardosolopes left a comment

Amazing, LGTM

bcardosolopes merged commit 00b21e0 into llvm:main

5 of 6 checks passed

Lancern deleted the dynamic-cast branch

February 2, 2024 13:28

Lancern mentioned this pull request

[CIR][CIRGen] Support dynamic_cast to void ptr #442

Merged

bcardosolopes pushed a commit that referenced this pull request


          [CIR][CIRGen] Support dynamic_cast to void ptr (#442)

4b46643

This patch adds CIRGen for downcasting a pointer to the complete object
through `dynamic_cast<void *>`.

Together with #426 , the full functionality of `dynamic_cast` should be
supported in CIRGen after this PR merges.

Lancern mentioned this pull request

[CIR] introduce cir.unreachable operation #447

Merged

bcardosolopes pushed a commit that referenced this pull request


          [CIR][CIRGen] Introduce cir.unreachable operation (#447)

76bb766

In #426 we confirmed that CIR needs a `cir.unreachable` operation to
mark unreachable program points
[(discussion)](#426 (comment)).
This PR adds it.

Lancern mentioned this pull request

CIR operation for dynamic_cast #470

Closed

lanza pushed a commit that referenced this pull request


          [CIR][CodeGen] Initial support for dynamic_cast (#426)

161b2a2

This PR introduces CIR CodeGen support for `dynamic_cast`.

The full feature set of `dynamic_cast` is not fully implemented in this
PR as it's already pretty large. This PR only include support for
downcasting and sidecasting a pointer or reference. `dynamic_cast<void
*>` is not yet implemented.

lanza pushed a commit that referenced this pull request


          [CIR][CIRGen] Support dynamic_cast to void ptr (#442)

be29342

This patch adds CIRGen for downcasting a pointer to the complete object
through `dynamic_cast<void *>`.

Together with #426 , the full functionality of `dynamic_cast` should be
supported in CIRGen after this PR merges.

lanza pushed a commit that referenced this pull request


          [CIR][CIRGen] Introduce cir.unreachable operation (#447)

1e30263

In #426 we confirmed that CIR needs a `cir.unreachable` operation to
mark unreachable program points
[(discussion)](#426 (comment)).
This PR adds it.

eZWALT pushed a commit to eZWALT/clangir that referenced this pull request


          [CIR][CodeGen] Initial support for dynamic_cast (llvm#426)

8b19764

This PR introduces CIR CodeGen support for `dynamic_cast`.

The full feature set of `dynamic_cast` is not fully implemented in this
PR as it's already pretty large. This PR only include support for
downcasting and sidecasting a pointer or reference. `dynamic_cast<void
*>` is not yet implemented.

eZWALT pushed a commit to eZWALT/clangir that referenced this pull request


          [CIR][CIRGen] Support dynamic_cast to void ptr (llvm#442)

74fba41

This patch adds CIRGen for downcasting a pointer to the complete object
through `dynamic_cast<void *>`.

Together with llvm#426 , the full functionality of `dynamic_cast` should be
supported in CIRGen after this PR merges.

eZWALT pushed a commit to eZWALT/clangir that referenced this pull request


          [CIR][CIRGen] Introduce cir.unreachable operation (llvm#447)

fecd27b

In llvm#426 we confirmed that CIR needs a `cir.unreachable` operation to
mark unreachable program points
[(discussion)](llvm#426 (comment)).
This PR adds it.

lanza pushed a commit that referenced this pull request


          [CIR][CodeGen] Initial support for dynamic_cast (#426)

2186f25

This PR introduces CIR CodeGen support for `dynamic_cast`.

The full feature set of `dynamic_cast` is not fully implemented in this
PR as it's already pretty large. This PR only include support for
downcasting and sidecasting a pointer or reference. `dynamic_cast<void
*>` is not yet implemented.

lanza pushed a commit that referenced this pull request


          [CIR][CIRGen] Support dynamic_cast to void ptr (#442)

11ff613

This patch adds CIRGen for downcasting a pointer to the complete object
through `dynamic_cast<void *>`.

Together with #426 , the full functionality of `dynamic_cast` should be
supported in CIRGen after this PR merges.

lanza pushed a commit that referenced this pull request


          [CIR][CIRGen] Introduce cir.unreachable operation (#447)

aa460dd

In #426 we confirmed that CIR needs a `cir.unreachable` operation to
mark unreachable program points
[(discussion)](#426 (comment)).
This PR adds it.

lanza pushed a commit that referenced this pull request


          [CIR][CodeGen] Initial support for dynamic_cast (#426)

e5d2bc2

This PR introduces CIR CodeGen support for `dynamic_cast`.

The full feature set of `dynamic_cast` is not fully implemented in this
PR as it's already pretty large. This PR only include support for
downcasting and sidecasting a pointer or reference. `dynamic_cast<void
*>` is not yet implemented.

lanza pushed a commit that referenced this pull request


          [CIR][CIRGen] Support dynamic_cast to void ptr (#442)

1edfbfa

This patch adds CIRGen for downcasting a pointer to the complete object
through `dynamic_cast<void *>`.

Together with #426 , the full functionality of `dynamic_cast` should be
supported in CIRGen after this PR merges.

lanza pushed a commit that referenced this pull request


          [CIR][CIRGen] Introduce cir.unreachable operation (#447)

6735e20

In #426 we confirmed that CIR needs a `cir.unreachable` operation to
mark unreachable program points
[(discussion)](#426 (comment)).
This PR adds it.

eZWALT pushed a commit to eZWALT/clangir that referenced this pull request


          [CIR][CodeGen] Initial support for dynamic_cast (llvm#426)

c068b6f

This PR introduces CIR CodeGen support for `dynamic_cast`.

The full feature set of `dynamic_cast` is not fully implemented in this
PR as it's already pretty large. This PR only include support for
downcasting and sidecasting a pointer or reference. `dynamic_cast<void
*>` is not yet implemented.

eZWALT pushed a commit to eZWALT/clangir that referenced this pull request


          [CIR][CIRGen] Support dynamic_cast to void ptr (llvm#442)

01769bd

This patch adds CIRGen for downcasting a pointer to the complete object
through `dynamic_cast<void *>`.

Together with llvm#426 , the full functionality of `dynamic_cast` should be
supported in CIRGen after this PR merges.

eZWALT pushed a commit to eZWALT/clangir that referenced this pull request


          [CIR][CIRGen] Introduce cir.unreachable operation (llvm#447)

f7355b2

In llvm#426 we confirmed that CIR needs a `cir.unreachable` operation to
mark unreachable program points
[(discussion)](llvm#426 (comment)).
This PR adds it.

lanza pushed a commit that referenced this pull request


          [CIR][CodeGen] Initial support for dynamic_cast (#426)

7b4745e

This PR introduces CIR CodeGen support for `dynamic_cast`.

The full feature set of `dynamic_cast` is not fully implemented in this
PR as it's already pretty large. This PR only include support for
downcasting and sidecasting a pointer or reference. `dynamic_cast<void
*>` is not yet implemented.

lanza pushed a commit that referenced this pull request


          [CIR][CIRGen] Support dynamic_cast to void ptr (#442)

c35b579

This patch adds CIRGen for downcasting a pointer to the complete object
through `dynamic_cast<void *>`.

Together with #426 , the full functionality of `dynamic_cast` should be
supported in CIRGen after this PR merges.

lanza pushed a commit that referenced this pull request


          [CIR][CIRGen] Introduce cir.unreachable operation (#447)

d3b91b5

In #426 we confirmed that CIR needs a `cir.unreachable` operation to
mark unreachable program points
[(discussion)](#426 (comment)).
This PR adds it.

pysuxing pushed a commit to pysuxing/llvm-project that referenced this pull request


          [CIR][CIRGen] Introduce cir.unreachable operation (llvm#447)

f3e4650

In llvm#426 we confirmed that CIR needs a `cir.unreachable` operation to
mark unreachable program points
[(discussion)](llvm/clangir#426 (comment)).
This PR adds it.

bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request


          [CIR][CodeGen] Initial support for dynamic_cast (llvm#426)

c56dc0b

This PR introduces CIR CodeGen support for `dynamic_cast`.

The full feature set of `dynamic_cast` is not fully implemented in this
PR as it's already pretty large. This PR only include support for
downcasting and sidecasting a pointer or reference. `dynamic_cast<void
*>` is not yet implemented.

bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request


          [CIR][CIRGen] Support dynamic_cast to void ptr (llvm#442)

9d1a1c2

This patch adds CIRGen for downcasting a pointer to the complete object
through `dynamic_cast<void *>`.

Together with llvm#426 , the full functionality of `dynamic_cast` should be
supported in CIRGen after this PR merges.

Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request


          [CIR][CodeGen] Initial support for dynamic_cast (llvm#426)

c23cc02

This PR introduces CIR CodeGen support for `dynamic_cast`.

The full feature set of `dynamic_cast` is not fully implemented in this
PR as it's already pretty large. This PR only include support for
downcasting and sidecasting a pointer or reference. `dynamic_cast<void
*>` is not yet implemented.

Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request


          [CIR][CIRGen] Support dynamic_cast to void ptr (llvm#442)

82c3593

This patch adds CIRGen for downcasting a pointer to the complete object
through `dynamic_cast<void *>`.

Together with llvm#426 , the full functionality of `dynamic_cast` should be
supported in CIRGen after this PR merges.

Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request


          [CIR][CIRGen] Introduce cir.unreachable operation (llvm#447)

c858970

In llvm#426 we confirmed that CIR needs a `cir.unreachable` operation to
mark unreachable program points
[(discussion)](llvm#426 (comment)).
This PR adds it.

keryell pushed a commit to keryell/clangir that referenced this pull request


          [CIR][CodeGen] Initial support for dynamic_cast (llvm#426)

6fee0c9

This PR introduces CIR CodeGen support for `dynamic_cast`.

The full feature set of `dynamic_cast` is not fully implemented in this
PR as it's already pretty large. This PR only include support for
downcasting and sidecasting a pointer or reference. `dynamic_cast<void
*>` is not yet implemented.

keryell pushed a commit to keryell/clangir that referenced this pull request


          [CIR][CIRGen] Support dynamic_cast to void ptr (llvm#442)

e98cdfb

This patch adds CIRGen for downcasting a pointer to the complete object
through `dynamic_cast<void *>`.

Together with llvm#426 , the full functionality of `dynamic_cast` should be
supported in CIRGen after this PR merges.

keryell pushed a commit to keryell/clangir that referenced this pull request


          [CIR][CIRGen] Introduce cir.unreachable operation (llvm#447)

a73cdf5

In llvm#426 we confirmed that CIR needs a `cir.unreachable` operation to
mark unreachable program points
[(discussion)](llvm#426 (comment)).
This PR adds it.

lanza pushed a commit that referenced this pull request


          [CIR][CodeGen] Initial support for dynamic_cast (#426)

39725dc

This PR introduces CIR CodeGen support for `dynamic_cast`.

The full feature set of `dynamic_cast` is not fully implemented in this
PR as it's already pretty large. This PR only include support for
downcasting and sidecasting a pointer or reference. `dynamic_cast<void
*>` is not yet implemented.

lanza pushed a commit that referenced this pull request


          [CIR][CIRGen] Support dynamic_cast to void ptr (#442)

0cea9f2

This patch adds CIRGen for downcasting a pointer to the complete object
through `dynamic_cast<void *>`.

Together with #426 , the full functionality of `dynamic_cast` should be
supported in CIRGen after this PR merges.

lanza pushed a commit that referenced this pull request


          [CIR][CIRGen] Introduce cir.unreachable operation (#447)

923ec04

In #426 we confirmed that CIR needs a `cir.unreachable` operation to
mark unreachable program points
[(discussion)](#426 (comment)).
This PR adds it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet