[CIR][Lowering] Support conversion of cir.zero to dense consts #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
@gitoleg Could you take a look on this PR draft and express your opinion about this? |
gitoleg
reviewed
Jan 23, 2024
|
LGTM except one minor stylish thing :) |
YazZz1k
force-pushed
the
cpp-124
branch
2 times, most recently
from
52508b2 to
925e9a3
Compare
YazZz1k
changed the title
lanza
force-pushed
the
main
branch
2 times, most recently
from
4e069c6 to
79d4dc7
Compare
|
@lanza just rebased and this has the side effect of breaking GH PR workflow, making it impossible to review, apologies. Please rebase! |
bcardosolopes
requested changes
Feb 1, 2024
bcardosolopes
approved these changes
Feb 2, 2024
lanza
pushed a commit
that referenced
this pull request
Mar 23, 2024
Compiling the given c-code
```
void foo() {
int i [2][1] = { { 1 }, { 0 } };
long int li[2][1] = { { 1 }, { 0 } };
float fl[2][1] = { { 1 }, { 0 } };
double d [2][1] = { { 1 }, { 0 } };
}
```
leads to compilation error
```
unknown element in ConstArrayAttr
UNREACHABLE executed at /home/huawei/cir/repo/van/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:951!
```
PR implements conversion the cir.zero attr to dense constant and fixed
this error.
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
) Compiling the given c-code ``` void foo() { int i [2][1] = { { 1 }, { 0 } }; long int li[2][1] = { { 1 }, { 0 } }; float fl[2][1] = { { 1 }, { 0 } }; double d [2][1] = { { 1 }, { 0 } }; } ``` leads to compilation error ``` unknown element in ConstArrayAttr UNREACHABLE executed at /home/huawei/cir/repo/van/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:951! ``` PR implements conversion the cir.zero attr to dense constant and fixed this error.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Compiling the given c-code
```
void foo() {
int i [2][1] = { { 1 }, { 0 } };
long int li[2][1] = { { 1 }, { 0 } };
float fl[2][1] = { { 1 }, { 0 } };
double d [2][1] = { { 1 }, { 0 } };
}
```
leads to compilation error
```
unknown element in ConstArrayAttr
UNREACHABLE executed at /home/huawei/cir/repo/van/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:951!
```
PR implements conversion the cir.zero attr to dense constant and fixed
this error.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Compiling the given c-code
```
void foo() {
int i [2][1] = { { 1 }, { 0 } };
long int li[2][1] = { { 1 }, { 0 } };
float fl[2][1] = { { 1 }, { 0 } };
double d [2][1] = { { 1 }, { 0 } };
}
```
leads to compilation error
```
unknown element in ConstArrayAttr
UNREACHABLE executed at /home/huawei/cir/repo/van/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:951!
```
PR implements conversion the cir.zero attr to dense constant and fixed
this error.
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
) Compiling the given c-code ``` void foo() { int i [2][1] = { { 1 }, { 0 } }; long int li[2][1] = { { 1 }, { 0 } }; float fl[2][1] = { { 1 }, { 0 } }; double d [2][1] = { { 1 }, { 0 } }; } ``` leads to compilation error ``` unknown element in ConstArrayAttr UNREACHABLE executed at /home/huawei/cir/repo/van/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:951! ``` PR implements conversion the cir.zero attr to dense constant and fixed this error.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Compiling the given c-code
```
void foo() {
int i [2][1] = { { 1 }, { 0 } };
long int li[2][1] = { { 1 }, { 0 } };
float fl[2][1] = { { 1 }, { 0 } };
double d [2][1] = { { 1 }, { 0 } };
}
```
leads to compilation error
```
unknown element in ConstArrayAttr
UNREACHABLE executed at /home/huawei/cir/repo/van/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:951!
```
PR implements conversion the cir.zero attr to dense constant and fixed
this error.
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
) Compiling the given c-code ``` void foo() { int i [2][1] = { { 1 }, { 0 } }; long int li[2][1] = { { 1 }, { 0 } }; float fl[2][1] = { { 1 }, { 0 } }; double d [2][1] = { { 1 }, { 0 } }; } ``` leads to compilation error ``` unknown element in ConstArrayAttr UNREACHABLE executed at /home/huawei/cir/repo/van/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:951! ``` PR implements conversion the cir.zero attr to dense constant and fixed this error.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
) Compiling the given c-code ``` void foo() { int i [2][1] = { { 1 }, { 0 } }; long int li[2][1] = { { 1 }, { 0 } }; float fl[2][1] = { { 1 }, { 0 } }; double d [2][1] = { { 1 }, { 0 } }; } ``` leads to compilation error ``` unknown element in ConstArrayAttr UNREACHABLE executed at /home/huawei/cir/repo/van/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:951! ``` PR implements conversion the cir.zero attr to dense constant and fixed this error.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
) Compiling the given c-code ``` void foo() { int i [2][1] = { { 1 }, { 0 } }; long int li[2][1] = { { 1 }, { 0 } }; float fl[2][1] = { { 1 }, { 0 } }; double d [2][1] = { { 1 }, { 0 } }; } ``` leads to compilation error ``` unknown element in ConstArrayAttr UNREACHABLE executed at /home/huawei/cir/repo/van/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:951! ``` PR implements conversion the cir.zero attr to dense constant and fixed this error.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
Compiling the given c-code
```
void foo() {
int i [2][1] = { { 1 }, { 0 } };
long int li[2][1] = { { 1 }, { 0 } };
float fl[2][1] = { { 1 }, { 0 } };
double d [2][1] = { { 1 }, { 0 } };
}
```
leads to compilation error
```
unknown element in ConstArrayAttr
UNREACHABLE executed at /home/huawei/cir/repo/van/llvm-project/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp:951!
```
PR implements conversion the cir.zero attr to dense constant and fixed
this error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling the given c-code
leads to compilation error
PR implements conversion the cir.zero attr to dense constant and fixed this error.