Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][IR] Refactor for loops #409

Merged
merged 5 commits into from
Jan 22, 2024
Merged

[CIR][IR] Refactor for loops #409

merged 5 commits into from
Jan 22, 2024

Conversation

sitio-couto
Copy link
Collaborator

@sitio-couto sitio-couto commented Jan 18, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

This patch completes the deprecation of the generic cir.loop operation
by adding a new cir.for operation and removing the cir.loop op. The
new representation removes some bloat and places the regions in order of
execution.

@sitio-couto
[CIR][IR] Refactor for loops
c2af4c7 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

[ghstack-poisoned]
This was referenced Jan 18, 2024
Merged
Merged
Merged
Merged
sitio-couto added a commit that referenced this pull request Jan 18, 2024
@sitio-couto
[CIR][IR] Refactor for loops
29a741d 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: f031dabf5f96ceaed8d25c5fe3ce5f3564fec3a3
Pull Request resolved: #409
@sitio-couto
Update on "[CIR][IR] Refactor for loops"
eaa7f6b 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

[ghstack-poisoned]
sitio-couto added a commit that referenced this pull request Jan 18, 2024
@sitio-couto
[CIR][IR] Refactor for loops
653deea 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: f031dabf5f96ceaed8d25c5fe3ce5f3564fec3a3
Pull Request resolved: #409
bcardosolopes
bcardosolopes approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One extra nice addition for later PR is you feel encouraged: split the loop operations into a CIRLoopOps.td, and start the trend for having more horizonal op files.

@sitio-couto
Update on "[CIR][IR] Refactor for loops"
03112b7 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

[ghstack-poisoned]
sitio-couto added a commit that referenced this pull request Jan 20, 2024
@sitio-couto
[CIR][IR] Refactor for loops
722acec 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 894d8c491e18ea2eacc8b255288ca24fe15a7433
Pull Request resolved: #409
@sitio-couto
Update on "[CIR][IR] Refactor for loops"
0b97c00 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

[ghstack-poisoned]
sitio-couto added a commit that referenced this pull request Jan 20, 2024
@sitio-couto
[CIR][IR] Refactor for loops
8396ed6 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: c8184ed4da74c9bce433a5cf78798700c572ebec
Pull Request resolved: #409
@sitio-couto
Update on "[CIR][IR] Refactor for loops"
3bd9575 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

[ghstack-poisoned]
sitio-couto added a commit that referenced this pull request Jan 22, 2024
@sitio-couto
[CIR][IR] Refactor for loops
9562623 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: #409
@sitio-couto sitio-couto merged commit 3bd9575 into gh/sitio-couto/6/base Jan 22, 2024
sitio-couto added a commit that referenced this pull request Jan 22, 2024
@sitio-couto
[CIR][IR] Refactor for loops
d54606d 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: #409
@sitio-couto sitio-couto deleted the gh/sitio-couto/6/head branch January 22, 2024 20:26
lanza pushed a commit that referenced this pull request Jan 29, 2024
@sitio-couto @lanza
[CIR][IR] Refactor for loops
f7edc9e 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: #409
lanza pushed a commit that referenced this pull request Mar 23, 2024
@sitio-couto @lanza
[CIR][IR] Refactor for loops
e82231e 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: #409
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@sitio-couto @lanza
[CIR][IR] Refactor for loops
549f3da 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: llvm#409
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][IR] Refactor for loops
65148f1 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: #409
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][IR] Refactor for loops
4a769f0 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: #409
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][IR] Refactor for loops
d873121 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: llvm#409
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][IR] Refactor for loops
7bd9fe3 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: #409
pysuxing pushed a commit to pysuxing/llvm-project that referenced this pull request Jul 17, 2024
@sitio-couto @lanza
[CIR][IR] Refactor for loops
35eb373 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: llvm/clangir#409
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@sitio-couto @lanza
[CIR][IR] Refactor for loops
beea238 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: llvm#409
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@sitio-couto @lanza
[CIR][IR] Refactor for loops
7820615 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: llvm#409
lanza pushed a commit that referenced this pull request Nov 5, 2024
@sitio-couto @lanza
[CIR][IR] Refactor for loops
e70f53d 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: #409
lanza pushed a commit that referenced this pull request Mar 18, 2025
@sitio-couto @lanza
[CIR][IR] Refactor for loops
413c9c4 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: #409
xlauko pushed a commit to trailofbits/instafix-llvm that referenced this pull request Mar 28, 2025
@sitio-couto @xlauko
[CIR][IR] Refactor for loops
f10102e 
This patch completes the deprecation of the generic `cir.loop` operation
by adding a new `cir.for` operation and removing the `cir.loop` op. The
new representation removes some bloat and places the regions in order of
execution.

ghstack-source-id: 886e0dacc632e5809015e2212810d690ef3ec294
Pull Request resolved: llvm/clangir#409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sitio-couto @bcardosolopes