[CIR][ThroughMLIR] Templatize unary math op lowerings. #1557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goxul
changed the title
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
Could we use TableGen for this? AFAIK, these conversion patterns for intrinsics in the LowerToLLVM pass are generated. (See |
I found the PR here which introduced these changes -- let me see if I can remodel this PR to use TableGen, instead of a template. Just found this comment by @bcardosolopes as well which suggests the same. |
|
All test failures are unrelated, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the unary math op lowerings follow the same template -- we can templatize this to remove redundant code and make things a little more neater. (Similar to what we do here)
I've checked all existing LIT tests via
ninja clang-check-cirand they seem to be passing fine.