Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach CIR pointers about address space #418

Closed
bcardosolopes opened this issue Jan 23, 2024 · 4 comments
Closed

Teach CIR pointers about address space #418

bcardosolopes opened this issue Jan 23, 2024 · 4 comments
Assignees
@seven-mile

Comments

@bcardosolopes
Copy link
Member

bcardosolopes commented Jan 23, 2024 •
edited
Loading

We don't support that yet. A good place to start is to change addressSpace() and addressSpaceInGlobalVar() functions to return true in clang/lib/CIR/CodeGen/UnimplementedFeatureGuarding.h, run ninja check-clang-cir and start working over the found crashes.

(cc: @sommerlukas @sitio-couto)
@seven-mile
Copy link
Collaborator

Maybe it's OK to assign this to me? It's a general issue though.

@bcardosolopes
Copy link
Member Author

Sure!

@seven-mile seven-mile mentioned this issue May 15, 2024
Merged
bcardosolopes pushed a commit that referenced this issue May 20, 2024
@seven-mile
[CIR][CIRGen][LowerToLLVM] Add address space attribute for pointer ty…
1166bdb 
…pe (#606)

This is the prelude of address space support. Linked issue: #418 .

- Add the attribute and implement asm format & type conversion.
- Make ops like `cir.global` and `cir.get_global` aware of address space, and solve the latter flag.
- Relax the restriction of default alloca address space. Then we can use correct address spaces for languages like OpenCL in future.
@bcardosolopes
Copy link
Member Author

@seven-mile let me know once we can close this.

@seven-mile seven-mile mentioned this issue Jun 15, 2024
Closed
@seven-mile
Copy link
Collaborator

Solved in #724.

bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this issue Oct 2, 2024
@seven-mile @lanza
[CIR][CIRGen][LowerToLLVM] Add address space attribute for pointer ty…
1bf48dc 
…pe (llvm#606)

This is the prelude of address space support. Linked issue: llvm#418 .

- Add the attribute and implement asm format & type conversion.
- Make ops like `cir.global` and `cir.get_global` aware of address space, and solve the latter flag.
- Relax the restriction of default alloca address space. Then we can use correct address spaces for languages like OpenCL in future.
Hugobros3 pushed a commit to shady-gang/clangir that referenced this issue Oct 2, 2024
@seven-mile @lanza
[CIR][CIRGen][LowerToLLVM] Add address space attribute for pointer ty…
093ee15 
…pe (llvm#606)

This is the prelude of address space support. Linked issue: llvm#418 .

- Add the attribute and implement asm format & type conversion.
- Make ops like `cir.global` and `cir.get_global` aware of address space, and solve the latter flag.
- Relax the restriction of default alloca address space. Then we can use correct address spaces for languages like OpenCL in future.
keryell pushed a commit to keryell/clangir that referenced this issue Oct 19, 2024
@seven-mile @lanza
[CIR][CIRGen][LowerToLLVM] Add address space attribute for pointer ty…
8dede2e 
…pe (llvm#606)

This is the prelude of address space support. Linked issue: llvm#418 .

- Add the attribute and implement asm format & type conversion.
- Make ops like `cir.global` and `cir.get_global` aware of address space, and solve the latter flag.
- Relax the restriction of default alloca address space. Then we can use correct address spaces for languages like OpenCL in future.
lanza pushed a commit that referenced this issue Nov 5, 2024
@seven-mile @lanza
[CIR][CIRGen][LowerToLLVM] Add address space attribute for pointer ty…
7f3444a 
…pe (#606)

This is the prelude of address space support. Linked issue: #418 .

- Add the attribute and implement asm format & type conversion.
- Make ops like `cir.global` and `cir.get_global` aware of address space, and solve the latter flag.
- Relax the restriction of default alloca address space. Then we can use correct address spaces for languages like OpenCL in future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seven-mile seven-mile

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcardosolopes @seven-mile