[Python] Switch CIRCT Python extension and dialects to nanobind. #8110
Conversation
This follows the general nanobind porting guide and the upstream MLIR changes in the same vein. For the most part, this is a very direct migration accomplished with sed. There were a couple minor differences. Nanobind is more strict about implicit casting, which popped up in a couple places: * In MSFTModule, getNearestFreeInColumn was expecting a CIRCTMSFTPrimitiveType (int), but was actually being passed PrimitiveType enums at the call sites. Nanobind refused to automatically cast enum to int, so it was done manually. * In SVModule, SVAttributeAttr.get was expecting a bool for emitAsComment, even though it was declared as having a default of None. Nanobind refused to automatically cast None to bool, so it was done manually, with a default of false. Nanobind also prints enums slightly differently, so one FileCheck test had to be updated for ESI. Otherwise, the changes were purely mechanical.
mikeurbach
force-pushed
the
mikeurbach/nanobind
branch
from
7198728 to
e30ed45
Compare
There was a problem hiding this comment.
LGTM!
Will this work on Windows? We still don't have the integration tests running on the Windows builds (since they still fail). I'll have a go at checking on Windows, though it may take me a few days so feel free to land this. I'm probably the only one who has to care about Windows.
|
I don't know, and don't currently have a Windows environment, but I'm cautiously optimistic, because I think upstream does care about Windows, and it seems stable upstream. |
|
Looks like wheels succeeded. Unfortunately, there was basically no change in the size: 20.9MB with nanobind, versus the previous wheels taking 21.0MB with pybind11. I'll take these wheels and see how the performance compares in a downstream tool. |
|
I'm gonna go ahead and land this. |
This follows the general nanobind porting guide and the upstream MLIR changes in the same vein. For the most part, this is a very direct migration accomplished with sed.
There were a couple minor differences.
Nanobind is more strict about implicit casting, which popped up in a couple places:
Nanobind also prints enums slightly differently, so one FileCheck test had to be updated for ESI.
Otherwise, the changes were purely mechanical.