Refectoring MslsAdminIcon and MslsAdminIconTaxonomy

lloc · Aug 7, 2023 · ecc4ddd · ecc4ddd
1 parent ef1a72a
commit ecc4ddd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/includes/MslsAdminIcon.php b/includes/MslsAdminIcon.php
@@ -88,21 +88,18 @@ public function __toString() {
 	/**
 	 * @codeCoverageIgnore
 	 *
-	 * @param null $type
+	 * @param ?string $type
 	 *
 	 * @return MslsAdminIcon|MslsAdminIconTaxonomy
 	 */
-	public static function create( $type = null ) {
+	public static function create( ?string $type = null ) {
 		$obj = MslsContentTypes::create();
 
 		if ( ! $type ) {
 			$type = $obj->get_request();
 		}
-		if ( $obj->is_taxonomy() ) {
-			return new MslsAdminIconTaxonomy( $type );
-		}
 
-		return new MslsAdminIcon( $type );
+		return $obj->is_taxonomy() ? new MslsAdminIconTaxonomy( $type ) : new MslsAdminIcon( $type );
 	}
 
 	/**

diff --git a/includes/MslsBlog.php b/includes/MslsBlog.php
@@ -1,14 +1,10 @@
 <?php
-/**
- * MslsBlog
- * @author Dennis Ploetner <[email protected]>
- * @since 0.9.8
- */
 
 namespace lloc\Msls;
 
 /**
  * Internal representation of a blog
+ *
  * @property int $userblog_id
  * @package Msls
  */

diff --git a/tests/test-mslsadmin.php b/tests/test-mslsadmin.php
@@ -8,7 +8,6 @@
 use lloc\Msls\MslsBlog;
 use lloc\Msls\MslsOptions;
 use lloc\Msls\MslsBlogCollection;
-use Mockery\Mock;
 
 class WP_Test_MslsAdmin extends Msls_UnitTestCase {