Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update workflows to use latest versions of the actions #285

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

vt-alt
Copy link
Contributor

@vt-alt vt-alt commented Aug 21, 2023

This should quiet the warning:

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

@vt-alt
Copy link
Contributor Author

vt-alt commented Aug 21, 2023

Hmm, openSUSE builds also got broken (missing awk and git in their runs). perhaps this is unrelated to actions update and related to some docker image update since previous successful docker build was long 3 weeks ago. I will try add commit with a fix later to this PR.

@solardiz
Copy link
Contributor

I will try add commit with a fix later to this PR.

Thank you, @vt-alt! I assume this is not to be merged yet?

@vt-alt
Copy link
Contributor Author

vt-alt commented Aug 24, 2023

I filed issue into GH checkout/action but they did not reply. This mean we will be not able to retain opensuse/leap for tests. If you are OK with it, I will add commit deleting it.

opensuse/tumbleweed fixes if we add gawk to zypper install.

ps. I said before 'it misses git' but I was incorrectly identified problem att.

@solardiz
Copy link
Contributor

we will be not able to retain opensuse/leap for tests. If you are OK with it, I will add commit deleting it.

I would be OK with it if there were a better reason to do it, but removing a currently working test just to silence a warning does not feel like a good tradeoff. Do I understand this correctly? What do you think?

@vt-alt
Copy link
Contributor Author

vt-alt commented Aug 24, 2023

Them we shall not merge it and postpone this until tests really fail with v1.

@vt-alt vt-alt closed this Aug 24, 2023
@vt-alt
Copy link
Contributor Author

vt-alt commented Aug 25, 2023

Perhaps they started to use tar from inside of contained in @v3, and leap image does not have it (but tumbleweed have it). So if I install tar and gzip (and reorder steps) build starting to work again. I reopen, and will push fixed version later today.

@vt-alt vt-alt reopened this Aug 25, 2023
This should fix the warning:

  The following actions uses node12 which is deprecated and will be
  forced to run on node16: actions/checkout@v2. For more info:
  https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Signed-off-by: Vitaly Chikunov <[email protected]>
@vt-alt
Copy link
Contributor Author

vt-alt commented Aug 25, 2023

Can be merged now I think.

@solardiz solardiz merged commit 544479d into lkrg-org:main Aug 26, 2023
20 checks passed
@vt-alt vt-alt deleted the node16 branch August 6, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants