fix win10 build #552
Merged
fix win10 build #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recent pip (version 23.0 or later) cannot install packages to a host system without explicit option thus, failed under github actions. This commit fixes this issue. Link: pypa/pip#11381 Signed-off-by: Hajime Tazaki <[email protected]>
This commit fixes the warnings (i.e., SyntaxWarning: invalid escape sequence) shown in later python version (after 3.12) during installation process of header files. Signed-off-by: Hajime Tazaki <[email protected]>
On windows build, python script should declar freeze_support() according to the document. This commit adds this line to our headers_install.py script. Link: https://docs.python.org/3.13/library/multiprocessing.html#multiprocessing.freeze_support Signed-off-by: Hajime Tazaki <[email protected]>
ddiss
approved these changes
Dec 30, 2024
| @@ -25,6 +25,7 @@ jobs: | |||
| - displayTargetName: windows-2019 | |||
| os: windows | |||
| runs_on: windows-2019 | |||
| pip_option: --break-system-packages | |||
There was a problem hiding this comment.
can we use the --user parameter to install to a local %APPDATA%\Python path instead of modifying the system python package? It's for CI so it probably doesn't matter...
There was a problem hiding this comment.
I think it can. For this CI, I wanted to reduce OS depends code so, used the nasty option(--break-system-packages) for that.
tavip
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.