lkl/tests: add disk parameters check to avoid segfaulting

Check for disk (image) and fstype parameters, to avoid segfaulting immediately. Failure to open the image or invalid fstype will still result in segfault. Signed-off-by: David Disseldorp <[email protected]>
lkl · Sep 8, 2023 · 2908898 · 2908898
1 parent db1e78e
commit 2908898
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/tools/lkl/tests/disk.c b/tools/lkl/tests/disk.c
@@ -126,7 +126,7 @@ static int lkl_test_opendir(void)
 
 	dir = lkl_opendir(mnt_point, &err);
 
-	lkl_test_logf("lkl_opedir(%s) = %d %s\n", mnt_point, err,
+	lkl_test_logf("lkl_opendir(%s) = %d %s\n", mnt_point, err,
 		      lkl_strerror(err));
 
 	if (err == 0)
@@ -182,6 +182,11 @@ int main(int argc, const char **argv)
 	if (parse_args(argc, argv, args) < 0)
 		return -1;
 
+	if (!cla.disk || !cla.fstype) {
+		fprintf(stderr, "disk and type parameters required.\n");
+		return -1;
+	}
+
 	lkl_host_ops.print = lkl_test_log;
 
 	lkl_init(&lkl_host_ops);