[Fix] no-is-mounted: fix logic in method name check

The last change to `no-is-mounted` caused the rule to error with any method name, not just with "isMounted".
ljharb · Sep 12, 2024 · a09083b · a09083b
1 parent 1df23d2
commit a09083b
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,11 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 
 ## Unreleased
 
+### Fixed
+* [`no-is-mounted`]: fix logic in method name check ([#3821][] @Mathias-S)
+
+[#3821]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3821
+
 ## [7.36.0] - 2024.09.12
 
 ### Added

diff --git a/lib/rules/no-is-mounted.js b/lib/rules/no-is-mounted.js
@@ -41,7 +41,8 @@ module.exports = {
         }
         if (
           callee.object.type !== 'ThisExpression'
-          && (!('name' in callee.property) || callee.property.name !== 'isMounted')
+          || !('name' in callee.property)
+          || callee.property.name !== 'isMounted'
         ) {
           return;
         }

diff --git a/tests/lib/rules/no-is-mounted.js b/tests/lib/rules/no-is-mounted.js
@@ -57,6 +57,17 @@ ruleTester.run('no-is-mounted', rule, {
         });
       `,
     },
+    {
+      code: `
+        class Hello extends React.Component {
+          notIsMounted() {}
+          render() {
+            this.notIsMounted();
+            return <div>Hello</div>;
+          }
+        };
+      `,
+    },
   ]),
 
   invalid: parsers.all([