[Tests] skip some tests that have broken ordering in certain node/esl…

…int combinations
ljharb · Aug 15, 2023 · 4779cb3 · 4779cb3
1 parent 9f46ad3
commit 4779cb3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 11 deletions.
diff --git a/tests/lib/rules/jsx-equals-spacing.js b/tests/lib/rules/jsx-equals-spacing.js
@@ -10,6 +10,7 @@
 // ------------------------------------------------------------------------------
 
 const RuleTester = require('eslint').RuleTester;
+const semver = require('semver');
 const rule = require('../../../lib/rules/jsx-equals-spacing');
 
 const parsers = require('../../helpers/parsers');
@@ -86,16 +87,16 @@ ruleTester.run('jsx-equals-spacing', rule, {
     },
   ]),
 
-  invalid: parsers.all([
-    {
+  invalid: parsers.all([].concat(
+    semver.satisfies(process.versions.node, '^8 || ^9') ? [] : {
       code: '<App foo = {bar} />',
       output: '<App foo={bar} />',
       errors: [
         { messageId: 'noSpaceBefore', type: 'JSXAttribute' },
         { messageId: 'noSpaceAfter', type: 'JSXAttribute' },
       ],
     },
-    {
+    semver.satisfies(process.versions.node, '^8 || ^9') ? [] : {
       code: '<App foo = {bar} />',
       output: '<App foo={bar} />',
       options: ['never'],
@@ -116,7 +117,7 @@ ruleTester.run('jsx-equals-spacing', rule, {
       options: ['never'],
       errors: [{ messageId: 'noSpaceAfter', type: 'JSXAttribute' }],
     },
-    {
+    semver.satisfies(process.versions.node, '^8 || ^9') ? [] : {
       code: '<App foo= {bar} bar = {baz} />',
       output: '<App foo={bar} bar={baz} />',
       options: ['never'],
@@ -126,7 +127,7 @@ ruleTester.run('jsx-equals-spacing', rule, {
         { messageId: 'noSpaceAfter', type: 'JSXAttribute' },
       ],
     },
-    {
+    semver.satisfies(process.versions.node, '^8 || ^9') ? [] : {
       code: '<App foo={bar} />',
       output: '<App foo = {bar} />',
       options: ['always'],
@@ -147,7 +148,7 @@ ruleTester.run('jsx-equals-spacing', rule, {
       options: ['always'],
       errors: [{ messageId: 'needSpaceBefore', type: 'JSXAttribute' }],
     },
-    {
+    semver.satisfies(process.versions.node, '^8 || ^9') ? [] : {
       code: '<App foo={bar} bar ={baz} />',
       output: '<App foo = {bar} bar = {baz} />',
       options: ['always'],
@@ -156,6 +157,6 @@ ruleTester.run('jsx-equals-spacing', rule, {
         { messageId: 'needSpaceAfter', type: 'JSXAttribute' },
         { messageId: 'needSpaceAfter', type: 'JSXAttribute' },
       ],
-    },
-  ]),
+    }
+  )),
 });
diff --git a/tests/lib/rules/no-invalid-html-attribute.js b/tests/lib/rules/no-invalid-html-attribute.js
@@ -10,6 +10,7 @@
 // ------------------------------------------------------------------------------
 
 const RuleTester = require('eslint').RuleTester;
+const semver = require('semver');
 const rule = require('../../../lib/rules/no-invalid-html-attribute');
 const parsers = require('../../helpers/parsers');
 
@@ -713,7 +714,7 @@ ruleTester.run('no-invalid-html-attribute', rule, {
         },
       ],
     },
-    {
+    semver.satisfies(process.versions.node, '^8 || ^9') ? [] : {
       code: '<a rel={"foobar batgo       noopener"}></a>',
       errors: [
         {
@@ -957,7 +958,7 @@ ruleTester.run('no-invalid-html-attribute', rule, {
         },
       ],
     },
-    {
+    semver.satisfies(process.versions.node, '^8 || ^9') ? [] : {
       code: '<link rel="shortcut  foo"></link>',
       errors: [
         {

diff --git a/tests/lib/rules/no-typos.js b/tests/lib/rules/no-typos.js
@@ -1873,7 +1873,7 @@ ruleTester.run('no-typos', rule, {
         },
       ],
     },
-    {
+    semver.satisfies(process.versions.node, '^8 || ^9') ? [] : {
       code: `
         class Hello extends React.Component {
           GetDerivedStateFromProps() { }