[Robustness] use cached copies of builtins

ljharb · Mar 21, 2024 · 97b0786 · 97b0786
1 parent 1d24d63
commit 97b0786
Show file tree

Hide file tree

Showing 41 changed files with 199 additions and 59 deletions.
diff --git a/2015/SetValueInBuffer.js b/2015/SetValueInBuffer.js
@@ -1,6 +1,9 @@
 'use strict';
 
+var GetIntrinsic = require('get-intrinsic');
+
 var $TypeError = require('es-errors/type');
+var $Uint8Array = GetIntrinsic('%Uint8Array%', true);
 
 var isInteger = require('../helpers/isInteger');
 
@@ -98,7 +101,7 @@ module.exports = function SetValueInBuffer(arrayBuffer, byteIndex, type, value)
 	}
 
 	// 12. Store the individual bytes of rawBytes into block, in order, starting at block[byteIndex].
-	var arr = new Uint8Array(arrayBuffer, byteIndex, elementSize);
+	var arr = new $Uint8Array(arrayBuffer, byteIndex, elementSize);
 	forEach(rawBytes, function (rawByte, i) {
 		arr[i] = rawByte;
 	});

diff --git a/2016/SetValueInBuffer.js b/2016/SetValueInBuffer.js
diff --git a/2017/SetValueInBuffer.js b/2017/SetValueInBuffer.js
diff --git a/2018/CreateAsyncFromSyncIterator.js b/2018/CreateAsyncFromSyncIterator.js
@@ -38,7 +38,7 @@ var AsyncFromSyncIteratorContinuation = function AsyncFromSyncIteratorContinuati
 		throw new $SyntaxError('This environment does not support Promises.');
 	}
 
-	return new Promise(function (resolve) {
+	return new $Promise(function (resolve) {
 		var done = IteratorComplete(result); // step 2
 		var value = IteratorValue(result); // step 4
 		var valueWrapper = PromiseResolve($Promise, value); // step 6
@@ -53,13 +53,17 @@ var AsyncFromSyncIteratorContinuation = function AsyncFromSyncIteratorContinuati
 
 var $AsyncFromSyncIteratorPrototype = GetIntrinsic('%AsyncFromSyncIteratorPrototype%', true) || {
 	next: function next(value) {
+		if (!$Promise) {
+			throw new $SyntaxError('This environment does not support Promises.');
+		}
+
 		var O = this; // step 1
 
 		SLOT.assert(O, '[[SyncIteratorRecord]]'); // step 2
 
 		var argsLength = arguments.length;
 
-		return new Promise(function (resolve) { // step 3
+		return new $Promise(function (resolve) { // step 3
 			var syncIteratorRecord = SLOT.get(O, '[[SyncIteratorRecord]]'); // step 4
 			var result;
 			if (argsLength > 0) {
@@ -71,14 +75,18 @@ var $AsyncFromSyncIteratorPrototype = GetIntrinsic('%AsyncFromSyncIteratorProtot
 		});
 	},
 	'return': function () {
+		if (!$Promise) {
+			throw new $SyntaxError('This environment does not support Promises.');
+		}
+
 		var O = this; // step 1
 
 		SLOT.assert(O, '[[SyncIteratorRecord]]'); // step 2
 
 		var valueIsPresent = arguments.length > 0;
 		var value = valueIsPresent ? arguments[0] : void undefined;
 
-		return new Promise(function (resolve, reject) { // step 3
+		return new $Promise(function (resolve, reject) { // step 3
 			var syncIterator = SLOT.get(O, '[[SyncIteratorRecord]]')['[[Iterator]]']; // step 4
 			var iteratorReturn = GetMethod(syncIterator, 'return'); // step 5
 
@@ -102,14 +110,18 @@ var $AsyncFromSyncIteratorPrototype = GetIntrinsic('%AsyncFromSyncIteratorProtot
 		});
 	},
 	'throw': function () {
+		if (!$Promise) {
+			throw new $SyntaxError('This environment does not support Promises.');
+		}
+
 		var O = this; // step 1
 
 		SLOT.assert(O, '[[SyncIteratorRecord]]'); // step 2
 
 		var valueIsPresent = arguments.length > 0;
 		var value = valueIsPresent ? arguments[0] : void undefined;
 
-		return new Promise(function (resolve, reject) { // step 3
+		return new $Promise(function (resolve, reject) { // step 3
 			var syncIterator = SLOT.get(O, '[[SyncIteratorRecord]]')['[[Iterator]]']; // step 4
 
 			var throwMethod = GetMethod(syncIterator, 'throw'); // step 5

diff --git a/2018/PromiseResolve.js b/2018/PromiseResolve.js
@@ -2,6 +2,7 @@
 
 var GetIntrinsic = require('get-intrinsic');
 var callBind = require('call-bind');
+var $SyntaxError = require('es-errors/syntax');
 
 var $resolve = GetIntrinsic('%Promise.resolve%', true);
 var $PromiseResolve = $resolve && callBind($resolve);
@@ -10,7 +11,7 @@ var $PromiseResolve = $resolve && callBind($resolve);
 
 module.exports = function PromiseResolve(C, x) {
 	if (!$PromiseResolve) {
-		throw new SyntaxError('This environment does not support Promises.');
+		throw new $SyntaxError('This environment does not support Promises.');
 	}
 	return $PromiseResolve(C, x);
 };

diff --git a/2018/SetValueInBuffer.js b/2018/SetValueInBuffer.js
diff --git a/2018/thisSymbolValue.js b/2018/thisSymbolValue.js
@@ -1,5 +1,6 @@
 'use strict';
 
+var $SyntaxError = require('es-errors/syntax');
 var callBound = require('call-bind/callBound');
 
 var $SymbolValueOf = callBound('Symbol.prototype.valueOf', true);
@@ -8,7 +9,7 @@ var $SymbolValueOf = callBound('Symbol.prototype.valueOf', true);
 
 module.exports = function thisSymbolValue(value) {
 	if (!$SymbolValueOf) {
-		throw new SyntaxError('Symbols are not supported; thisSymbolValue requires that `value` be a Symbol or a Symbol object');
+		throw new $SyntaxError('Symbols are not supported; thisSymbolValue requires that `value` be a Symbol or a Symbol object');
 	}
 	if (typeof value === 'symbol') {
 		return value;

diff --git a/2019/AsyncFromSyncIteratorContinuation.js b/2019/AsyncFromSyncIteratorContinuation.js
@@ -31,7 +31,7 @@ module.exports = function AsyncFromSyncIteratorContinuation(result) {
 		throw new $SyntaxError('This environment does not support Promises.');
 	}
 
-	return new Promise(function (resolve) {
+	return new $Promise(function (resolve) {
 		var done = IteratorComplete(result); // step 2
 		var value = IteratorValue(result); // step 4
 		var valueWrapper = PromiseResolve($Promise, value); // step 6

diff --git a/2019/CreateAsyncFromSyncIterator.js b/2019/CreateAsyncFromSyncIterator.js
@@ -2,7 +2,9 @@
 
 var GetIntrinsic = require('get-intrinsic');
 
+var $SyntaxError = require('es-errors/syntax');
 var $TypeError = require('es-errors/type');
+var $Promise = GetIntrinsic('%Promise%', true);
 
 var AsyncFromSyncIteratorContinuation = require('./AsyncFromSyncIteratorContinuation');
 var Call = require('./Call');
@@ -19,13 +21,17 @@ var SLOT = require('internal-slot');
 
 var $AsyncFromSyncIteratorPrototype = GetIntrinsic('%AsyncFromSyncIteratorPrototype%', true) || {
 	next: function next(value) {
+		if (!$Promise) {
+			throw new $SyntaxError('This environment does not support Promises.');
+		}
+
 		var O = this; // step 1
 
 		SLOT.assert(O, '[[SyncIteratorRecord]]'); // step 2
 
 		var argsLength = arguments.length;
 
-		return new Promise(function (resolve) { // step 3
+		return new $Promise(function (resolve) { // step 3
 			var syncIteratorRecord = SLOT.get(O, '[[SyncIteratorRecord]]'); // step 4
 			var result;
 			if (argsLength > 0) {
@@ -37,14 +43,18 @@ var $AsyncFromSyncIteratorPrototype = GetIntrinsic('%AsyncFromSyncIteratorProtot
 		});
 	},
 	'return': function () {
+		if (!$Promise) {
+			throw new $SyntaxError('This environment does not support Promises.');
+		}
+
 		var O = this; // step 1
 
 		SLOT.assert(O, '[[SyncIteratorRecord]]'); // step 2
 
 		var valueIsPresent = arguments.length > 0;
 		var value = valueIsPresent ? arguments[0] : void undefined;
 
-		return new Promise(function (resolve, reject) { // step 3
+		return new $Promise(function (resolve, reject) { // step 3
 			var syncIterator = SLOT.get(O, '[[SyncIteratorRecord]]')['[[Iterator]]']; // step 4
 			var iteratorReturn = GetMethod(syncIterator, 'return'); // step 5
 
@@ -68,14 +78,18 @@ var $AsyncFromSyncIteratorPrototype = GetIntrinsic('%AsyncFromSyncIteratorProtot
 		});
 	},
 	'throw': function () {
+		if (!$Promise) {
+			throw new $SyntaxError('This environment does not support Promises.');
+		}
+
 		var O = this; // step 1
 
 		SLOT.assert(O, '[[SyncIteratorRecord]]'); // step 2
 
 		var valueIsPresent = arguments.length > 0;
 		var value = valueIsPresent ? arguments[0] : void undefined;
 
-		return new Promise(function (resolve, reject) { // step 3
+		return new $Promise(function (resolve, reject) { // step 3
 			var syncIterator = SLOT.get(O, '[[SyncIteratorRecord]]')['[[Iterator]]']; // step 4
 
 			var throwMethod = GetMethod(syncIterator, 'throw'); // step 5

diff --git a/2019/PromiseResolve.js b/2019/PromiseResolve.js
diff --git a/2019/SetValueInBuffer.js b/2019/SetValueInBuffer.js
diff --git a/2019/thisSymbolValue.js b/2019/thisSymbolValue.js
diff --git a/2020/AsyncFromSyncIteratorContinuation.js b/2020/AsyncFromSyncIteratorContinuation.js
@@ -31,7 +31,7 @@ module.exports = function AsyncFromSyncIteratorContinuation(result) {
 		throw new $SyntaxError('This environment does not support Promises.');
 	}
 
-	return new Promise(function (resolve) {
+	return new $Promise(function (resolve) {
 		var done = IteratorComplete(result); // step 2
 		var value = IteratorValue(result); // step 4
 		var valueWrapper = PromiseResolve($Promise, value); // step 6

diff --git a/2020/CreateAsyncFromSyncIterator.js b/2020/CreateAsyncFromSyncIterator.js
@@ -2,7 +2,9 @@
 
 var GetIntrinsic = require('get-intrinsic');
 
+var $SyntaxError = require('es-errors/syntax');
 var $TypeError = require('es-errors/type');
+var $Promise = GetIntrinsic('%Promise%', true);
 
 var AsyncFromSyncIteratorContinuation = require('./AsyncFromSyncIteratorContinuation');
 var Call = require('./Call');
@@ -19,13 +21,17 @@ var SLOT = require('internal-slot');
 
 var $AsyncFromSyncIteratorPrototype = GetIntrinsic('%AsyncFromSyncIteratorPrototype%', true) || {
 	next: function next(value) {
+		if (!$Promise) {
+			throw new $SyntaxError('This environment does not support Promises.');
+		}
+
 		var O = this; // step 1
 
 		SLOT.assert(O, '[[SyncIteratorRecord]]'); // step 2
 
 		var argsLength = arguments.length;
 
-		return new Promise(function (resolve) { // step 3
+		return new $Promise(function (resolve) { // step 3
 			var syncIteratorRecord = SLOT.get(O, '[[SyncIteratorRecord]]'); // step 4
 			var result;
 			if (argsLength > 0) {
@@ -37,14 +43,18 @@ var $AsyncFromSyncIteratorPrototype = GetIntrinsic('%AsyncFromSyncIteratorProtot
 		});
 	},
 	'return': function () {
+		if (!$Promise) {
+			throw new $SyntaxError('This environment does not support Promises.');
+		}
+
 		var O = this; // step 1
 
 		SLOT.assert(O, '[[SyncIteratorRecord]]'); // step 2
 
 		var valueIsPresent = arguments.length > 0;
 		var value = valueIsPresent ? arguments[0] : void undefined;
 
-		return new Promise(function (resolve, reject) { // step 3
+		return new $Promise(function (resolve, reject) { // step 3
 			var syncIterator = SLOT.get(O, '[[SyncIteratorRecord]]')['[[Iterator]]']; // step 4
 			var iteratorReturn = GetMethod(syncIterator, 'return'); // step 5
 
@@ -68,14 +78,18 @@ var $AsyncFromSyncIteratorPrototype = GetIntrinsic('%AsyncFromSyncIteratorProtot
 		});
 	},
 	'throw': function () {
+		if (!$Promise) {
+			throw new $SyntaxError('This environment does not support Promises.');
+		}
+
 		var O = this; // step 1
 
 		SLOT.assert(O, '[[SyncIteratorRecord]]'); // step 2
 
 		var valueIsPresent = arguments.length > 0;
 		var value = valueIsPresent ? arguments[0] : void undefined;
 
-		return new Promise(function (resolve, reject) { // step 3
+		return new $Promise(function (resolve, reject) { // step 3
 			var syncIterator = SLOT.get(O, '[[SyncIteratorRecord]]')['[[Iterator]]']; // step 4
 
 			var throwMethod = GetMethod(syncIterator, 'throw'); // step 5