Fix compiler issues #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljgray
force-pushed
the
fix-compiler-issues
branch
from
45dc846 to
24d9fd2
Compare
ljgray
force-pushed
the
fix-compiler-issues
branch
2 times, most recently
from
1390af6 to
4e23e96
Compare
ljgray
force-pushed
the
fix-compiler-issues
branch
from
4e23e96 to
eb79dc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a long-standing issue which only became obvious with recent compiler updates (see kiyo-masui#153).
Changes to the structure of
H5Z_class_twere made in HDF5 versions 1.6, 1.8, and 1.8.3. The logic for selecting which class version to use inlzf_filter.cassumed the old class by default and only used the new class for HDF5 version 1.8.x. Based on kiyo-masui#153, it seems that some compilers recently started treating warnings generated by this old class structure as errors, causing bitshuffle to fail to build.This PR also updates python versions used in CI main and updates the version of HDF5 used in CI wheels.
Fixes
kiyo-masui#153
Supersedes
kiyo-masui/bitshuffle$154