Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming AC PR will require edits for compatibility #966

Open
blinkysc opened this issue Feb 13, 2025 · 17 comments
Open

Upcoming AC PR will require edits for compatibility #966

blinkysc opened this issue Feb 13, 2025 · 17 comments
Assignees

Comments

@blinkysc
Copy link
Contributor

Bug Description
This PR is a huge improvement and anticipate merge. It has many parts that will need to be edited to work with bots (azerothcore/azerothcore-wotlk#20955)

@blinkysc
Copy link
Contributor Author

Looks like will be merged for sure

Image

@zbhcn
Copy link

zbhcn commented Feb 16, 2025

Yes, this push has already been merged. It's a very good push, and we look forward to it being merged into this module as soon as possible.@liyunfan1223

@liyunfan1223
Copy link
Owner

Can u help with testing? #987 @zbhcn

@zbhcn
Copy link

zbhcn commented Feb 19, 2025

Can u help with testing? #987 @zbhcn

ok,which branch??

@liyunfan1223
Copy link
Owner

Check pull requests at #987 for mod and liyunfan1223/azerothcore-wotlk#40 for core.

@zbhcn
Copy link

zbhcn commented Feb 19, 2025

Check pull requests at #987 for mod and liyunfan1223/azerothcore-wotlk#40 for core.

Got it, thank you for your effort and work.

@nl-saw
Copy link
Collaborator

nl-saw commented Feb 19, 2025

That was fast! Compiling now.

@blinkysc
Copy link
Contributor Author

blinkysc commented Feb 19, 2025

I'll pull as well, wont be able to test much until later though
@Noscopezz I know you raid far more then me, you plan on raiding with your ICC scripting any time soon? If so mind trying with these PR's?

@nl-saw
Copy link
Collaborator

nl-saw commented Feb 19, 2025

Seems good so far.

@blinkysc
Copy link
Contributor Author

blinkysc commented Feb 19, 2025

Tried playing a bit and seems fine so far, I'll test later

  • Battleground behavior -> Was concerned about strand of ancient boat; seems good. Bots behavior seems fine
  • Transport behavior (maybe closes Bots glitching through the ground of ships #922 ??)
    • Seems like still issue (minor)
  • Pathing; test around terrains to make sure they can path correctly still
    - Sometimes bots will keep running around in circles (stuck in loop) even when next to you. Used hills around Tranquillien
  • Que, LFG. Pathing in dungeons

@liyunfan1223 looks good

@Noscopezz
Copy link
Contributor

Sure, I can test ICC, I will let you know how it goes.

@Noscopezz
Copy link
Contributor

High Overlord Saurfang and Garsoh Hellscream are at entrance in icc (they should not stand there, but they do nothing just afk so its not a big deal) when playing as Alliance.

On gunship bots seem more stable (they dont fall thru floor alot like they used to).

For Ally DBS is broken since instead of muradin, there is saurfang there and they cant start fight, for horde is ok. (someone should test this also, maybe its only my problem if db bugged somehow).

For some reason Horde is missing ICC buff, while Ally has it (Again could be a me problem).

Other bosses seem ok, they do the usuall bot stuff (freaking out here and there and flying sometimes).

Overall it seems ok and strategy works.

I will have more time to test over weekend.

@blinkysc
Copy link
Contributor Author

Hmmm seems like separate problems from map grid for some of those. Unless maybe somehow the map grid creates these odd bugs? Good to hear bot strats good though

@kadeshar
Copy link
Contributor

Eye of eternity Malygos is now muuuuuch better. I only tried once and almost killed him. Non bots fall through the floor.
Image

@blinkysc
Copy link
Contributor Author

@Noscopezz looks like some of your issues does have to deal with the Grid PR. Read the recent comments azerothcore/azerothcore-wotlk#20955 (comment)

@zbhcn
Copy link

zbhcn commented Feb 20, 2025

the test has been running for over 5 hours and remains stable without any crashes. the memory usage has decreased somewhat.However, the following log information appeared during the initialization of bot data: StaticTransport::Create: No AnimationInfo was found for GameObject entry (192517).@liyunfan1223

Image

welcomed to join and test on my public server.Should you require the server IP, please to send me a message.

@duhaowen
Copy link

测试已经运行了5个多小时,并且保持稳定,没有任何崩溃。内存使用量有所减少。然而,在初始化机器人数据期间出现了以下日志信息:StaticTransport::Create: No AnimationInfo was found for GameObject entry (192517)。@liyunfan1223

Image

欢迎加入并测试我的公共服务器。如果您需要服务器IP,请给我发消息。

Plz Ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants