Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powersaving #819

Open
Raz0r1337 opened this issue Dec 25, 2024 · 9 comments
Open

Powersaving #819

Raz0r1337 opened this issue Dec 25, 2024 · 9 comments
Labels
Enhancement New feature or request

Comments

@Raz0r1337
Copy link
Contributor

Raz0r1337 commented Dec 25, 2024

It would be very cool if no players are online all bots log out and login if a player comes back online.

This would save many CPU power over time, because most servers that runs 24/7 are the most of the time in idle.

I don't know how hard it is to implement such a feature but it would be great. Especially in the Homelab scene. We have many energy efficient servers and want to run a great WoW server for ourselves and family. 😉

@kadeshar
Copy link
Contributor

Im not sure about this.

  1. Exists option which keep active bots while real player is not near them. Setting that on 0 should disable bots to running when not real player near them.
    obraz

  2. Making bots online/offline when there is huge number configurated (for example 10k) can overlap itself when player loggin to game to check something and fast logout. Also randomization process while bot login add more server latency.

@noisiver
Copy link
Collaborator

I agree with @kadeshar to a certain extent.

If a user decides to quickly check on something, or even when they log in in order to actually play for some time, the server will have to deal with logging all those bots in every time. Imagine if you have to relog and it logs them all out and back in straight away. Performance will go to hell.

However, a grace period would solve that issue. A certain amount of time has to pass both before the bots are logged in and before they're logged out.

@Raz0r1337
Copy link
Contributor Author

Sorry,
but I thought that grace time is obvious in this feature. I don't want the server to instantly log off all bots if all users are gone. This causes many problems. What I mean is when all players go offline the bots wait a while and then they are going slow one by another offline. This is what the module already makes. It sets bots online or offline in addition to how many players are online. All I want is that if no one is online for a while it logs all bots off.

I will describe my ideas more in the future to avoid such misunderstandings in the future.

@noisiver
Copy link
Collaborator

It doesn't change the number of bots based on the number of players. The number of players doesn't come into effect, the only interaction the player has on the bots is if they're active or not (they're still logged in even if inactive).

@Raz0r1337
Copy link
Contributor Author

Raz0r1337 commented Dec 30, 2024

I've set min bots to 0 and max bots to 500.
The module logs bots on and offline.
I thought it is how I described it above because if no player is online for about 5 hours and I check the server console there are round 50 bots online. If I go with my char online the module logs more bots online. If my wife logs on to, more bots come online. 🤷

@noisiver
Copy link
Collaborator

The varying number of bots if min and max are set to different values isn't affected by the number of players. It just randomly generates a number between those two values and keeps that many bots logged in. It does so on a timer that's also randomized every time. I think by default it's 30 to 60 minutes.

@noisiver
Copy link
Collaborator

It's important that you know that I back your suggestion. It's a good idea and I think it should be a thing, but I also think it (eventually) should be an option to only log bots in to queue for battlegrounds, arenas and the dungeon finder and log out when the bg/arena/dungeon is done, so my taste is weird.

@Raz0r1337
Copy link
Contributor Author

Ok, good to know.
Looks so to me.

Thank you. I think it will be great if this feature is implemented. Thank you for your support.

@Raz0r1337
Copy link
Contributor Author

And we all have weird tastes. 😉🤣

@nl-saw nl-saw added the Enhancement New feature or request label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants