Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codepaths surrounded by quotes fail to work #32

Open
Aidan63 opened this issue Feb 18, 2019 · 4 comments
Open

Codepaths surrounded by quotes fail to work #32

Aidan63 opened this issue Feb 18, 2019 · 4 comments
Labels

Comments

@Aidan63
Copy link

Aidan63 commented Feb 18, 2019

Hello,
I've recently started using openfl's hxp library to generate hxml files. When you use hxp's HXML tool it will wrap any codepaths you specify in quotes, while this works fine with normal haxe with lix you get a 'classpath is not a directory or cannot be read from' error.
The culprit seems to be this line https://github.com/lix-pm/haxeshim/blob/master/src/haxeshim/HaxeCli.hx#L56 as I did some tests and haxe will throw an exception when pass a string surrounded in quotes to readDirectory. My solution for now was to modify hxp to not put quotes around the code paths but it would be nice to have haxeshim match haxe in this case.

Cheers.

@back2dos
Copy link
Contributor

So stripping any leading and trailing single and double quotes would do the trick?

@kevinresol
Copy link
Member

Maybe a good chance to factor out the hxml-parsing logic as a separate library?

@Aidan63
Copy link
Author

Aidan63 commented Feb 19, 2019

I think removing leading and trailing quotes would work, stopping hxp from adding them was the only thing I need to change to get it working with lix.

@back2dos
Copy link
Contributor

Maybe a good chance to factor out the hxml-parsing logic as a separate library?

Yes, although my gut feeling is that that's easier said than done :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants