Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chart_forground_style_scale modifier #97

Open
wants to merge 7 commits into
base: chart-scale-modifiers
Choose a base branch
from
Open

Add chart_forground_style_scale modifier #97

wants to merge 7 commits into from

Conversation

murtza
Copy link
Contributor

@murtza murtza commented Jul 3, 2023

Closes #18
Closes #19
Closes #20
Closes #21
Closes #22
Closes #23
Closes #24

@murtza murtza requested a review from carson-katri July 3, 2023 14:52
carson-katri
carson-katri requested changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@carson-katri carson-katri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR needs to have its base set to chart-scale-modifiers, since it uses some types added in that PR.

...s/LiveViewNativeCharts/Modifiers/View Fundamentals Modifiers/ChartForegroundStyleScale.swift Outdated Show resolved Hide resolved
@murtza murtza changed the base branch from main to chart-scale-modifiers July 4, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carson-katri carson-katri carson-katri requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modifier -> SwiftUI -> View fundamentals -> View -> Chart view modifiers: chartForegroundStyleScale(mapping:) Modifier -> SwiftUI -> View fundamentals -> View -> Chart view modifiers: chartForegroundStyleScale(domain:mapping:) Modifier -> SwiftUI -> View fundamentals -> View -> Chart view modifiers: chartForegroundStyleScale(domain:type:) Modifier -> SwiftUI -> View fundamentals -> View -> Chart view modifiers: chartForegroundStyleScale(domain:range:type:) Modifier -> SwiftUI -> View fundamentals -> View -> Chart view modifiers: chartForegroundStyleScale(_:)
Modifier -> SwiftUI -> View fundamentals -> View -> Chart view modifiers: chartForegroundStyleScale(range:type:) Modifier -> SwiftUI -> View fundamentals -> View -> Chart view modifiers: chartForegroundStyleScale(type:)
2 participants
@murtza @carson-katri